Adopt latest changes to request hash computation #6718
Merged
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `requestType` of empty lists is no longer part of the requests hash. - ethereum/EIPs#8989
|
Probably best to merge as part of when https://github.com/ethereum/consensus-specs/releases gets a 1.5.0-alpha.9. |
|
Tested using ethereum/consensus-specs#3998 -- hashes are the same across all consensus-spec-tests except the one that test 0-length transactions (status-im/nim-eth#744 (comment)). the 0-length tx is invalid anyway so it doesn't matter too much whether it gets rejected for invalid block hash or for being 0-length. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requestTypeof empty lists is no longer part of the requests hash.