Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] feat: trigger status-go panic button #16850

Closed
wants to merge 1 commit into from

Conversation

igor-sirotin
Copy link
Contributor

Caution

For testing purposes only. Do not merge.

Description

This PR adds a button that calls the IntendedPanic status-go endpoint.

How to test

  1. Get a production build of this PR with https://ci.infra.status.im/
  2. Have Share usage data with Status enabled
    Screenshot 2024-11-29 at 17 21 16
  3. Go to Settings -> Advanced and click Trigger status-go panic
    Screenshot 2024-11-29 at 17 21 22
  4. Check the generated random panic message in logs:
    panic: m430g1g4gyh0z [recovered]
    
  5. Find the panic with such code reported in Sentry
    Screenshot 2024-11-29 at 17 25 18

@igor-sirotin
Copy link
Contributor Author

I've noted that the panic report doesn't contain the full stacktrace:

image

But when I was testing it with status-backend, it looked like this:

image

Not sure what's wrong, will debug a bit more.

@igor-sirotin
Copy link
Contributor Author

cc @anastasiyaig @churik @ilmotta

@status-im-auto
Copy link
Member

status-im-auto commented Nov 29, 2024

Jenkins Builds

Click to see older builds (28)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6f3159c #1 2024-11-29 17:42:16 ~7 min macos/aarch64 🍎dmg
✔️ 6f3159c #1 2024-11-29 17:42:21 ~7 min tests/nim 📄log
✔️ 6f3159c #1 2024-11-29 17:47:07 ~12 min tests/ui 📄log
✔️ 6f3159c #1 2024-11-29 17:51:53 ~17 min linux/x86_64 📦tgz
✔️ 6f3159c #1 2024-11-29 17:52:17 ~17 min macos/x86_64 🍎dmg
✔️ 6f3159c #1 2024-11-29 17:53:48 ~19 min linux-nix/x86_64 📦tgz
✔️ 6f3159c #1 2024-11-29 18:02:41 ~28 min windows/x86_64 💿exe
✔️ d9204e8 #2 2024-11-29 20:58:35 ~6 min macos/aarch64 🍎dmg
✔️ d9204e8 #2 2024-11-29 20:59:56 ~7 min tests/nim 📄log
✔️ d9204e8 #2 2024-11-29 21:04:52 ~12 min tests/ui 📄log
✔️ d9204e8 #2 2024-11-29 21:07:27 ~15 min macos/x86_64 🍎dmg
✔️ d9204e8 #2 2024-11-29 21:08:31 ~16 min linux-nix/x86_64 📦tgz
✔️ d9204e8 #2 2024-11-29 21:14:20 ~22 min linux/x86_64 📦tgz
✔️ d9204e8 #2 2024-11-29 21:17:53 ~25 min windows/x86_64 💿exe
✔️ f1ab2f9 #3 2024-11-29 22:48:42 ~7 min tests/nim 📄log
✔️ f1ab2f9 #3 2024-11-29 22:53:09 ~11 min tests/ui 📄log
✔️ f1ab2f9 #3 2024-11-29 22:54:40 ~13 min linux-nix/x86_64 📦tgz
✔️ f1ab2f9 #3 2024-11-29 22:57:30 ~16 min macos/x86_64 🍎dmg
✔️ f1ab2f9 #3 2024-11-29 22:57:41 ~16 min macos/aarch64 🍎dmg
✔️ f1ab2f9 #3 2024-11-29 23:02:21 ~21 min linux/x86_64 📦tgz
✔️ f1ab2f9 #3 2024-11-29 23:06:14 ~24 min windows/x86_64 💿exe
✔️ 6cb7a55 #4 2024-12-03 16:45:22 ~8 min tests/nim 📄log
✔️ 6cb7a55 #4 2024-12-03 16:49:48 ~12 min tests/ui 📄log
✔️ 6cb7a55 #4 2024-12-03 17:01:27 ~24 min windows/x86_64 💿exe
✔️ 6cb7a55 #5 2024-12-03 17:03:19 ~22 min linux/x86_64 📦tgz
✔️ 6cb7a55 #5 2024-12-03 18:35:53 ~6 min macos/aarch64 🍎dmg
✔️ 6cb7a55 #6 2024-12-03 18:40:49 ~11 min macos/x86_64 🍎dmg
✔️ 6cb7a55 #5 2024-12-03 18:43:10 ~13 min linux-nix/x86_64 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e08e086 #5 2024-12-03 21:38:29 ~7 min tests/nim 📄log
✔️ e08e086 #6 2024-12-03 21:38:48 ~7 min macos/aarch64 🍎dmg
✔️ e08e086 #7 2024-12-03 21:42:35 ~11 min macos/x86_64 🍎dmg
✔️ e08e086 #5 2024-12-03 21:43:19 ~11 min tests/ui 📄log
✔️ e08e086 #6 2024-12-03 21:44:12 ~12 min linux-nix/x86_64 📦tgz
✔️ e08e086 #6 2024-12-03 21:51:50 ~20 min linux/x86_64 📦tgz
✔️ e08e086 #5 2024-12-03 21:55:21 ~23 min windows/x86_64 💿exe
✔️ 9758be5 #7 2024-12-04 20:27:28 ~6 min macos/aarch64 🍎dmg
✔️ 9758be5 #6 2024-12-04 20:28:52 ~8 min tests/nim 📄log
✔️ 9758be5 #8 2024-12-04 20:32:41 ~12 min macos/x86_64 🍎dmg
✔️ 9758be5 #7 2024-12-04 20:33:46 ~13 min linux-nix/x86_64 📦tgz
✔️ 9758be5 #6 2024-12-04 20:36:46 ~16 min tests/ui 📄log
✔️ 9758be5 #7 2024-12-04 20:40:57 ~20 min linux/x86_64 📦tgz
✔️ 9758be5 #6 2024-12-04 20:48:05 ~27 min windows/x86_64 💿exe

@igor-sirotin igor-sirotin force-pushed the feat/statusgo-intended-panic-button branch from d9204e8 to f1ab2f9 Compare November 29, 2024 22:40
@churik
Copy link
Member

churik commented Dec 2, 2024

@igor-sirotin can we get somehow a build for mobile to test it?

@ilmotta
Copy link

ilmotta commented Dec 2, 2024

@igor-sirotin can we get somehow a build for mobile to test it?

@churik, in this mobile PR status-im/status-mobile#21682 we will get a permanent way to trigger panics via the UI and it will be behind a feature flag, using the same feature flag system we use that is always disabled for users (release builds). I just need to finish it to take it out of draft.

In order to test the integration with the production Sentry project, I can temporarily change the PR to allow testing the Sentry panic button as a release build. Then I can easily revert that commit and leave the PR in a mergeable state with the option feature flagged. I'd still keep the feature flagged option to trigger panics because it will be useful again for mobile in the future.

@igor-sirotin igor-sirotin force-pushed the feat/statusgo-intended-panic-button branch from f1ab2f9 to 6cb7a55 Compare December 3, 2024 16:36
@igor-sirotin igor-sirotin force-pushed the feat/statusgo-intended-panic-button branch from e08e086 to 9758be5 Compare December 4, 2024 20:20
@igor-sirotin
Copy link
Contributor Author

Closing this as tested. If needed, we can always pick this up and embed under a feature flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants