-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mail client on android 13 fro sending logs #16408
Conversation
Jenkins BuildsClick to see older builds (57)
|
c2982a6
to
01f486c
Compare
e01b933
to
a6a261d
Compare
@VladimrLitvinenko would be nice if you take a look at this PR, I don't have that Pixel 7a device to test it |
65% of end-end tests have passed
Failed tests (12)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (22)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
|
76% of end-end tests have passed
Failed tests (8)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Passed tests (26)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
Hi @rasom the ability to share logs via Android 13 is fixed. A few new issues are found: ISSUE 1: The images are not fetched to the gallery for Android 10 devicesSteps to reproduce:
Actual result:
images_are_not_fetched.mp4Expected result:Images are shown in the opened gallery images.mp4Device:Android Studio device: Pixel XL API 29 |
ISSUE 2: "Open Gallery" button is unresponsive on Android 13Steps to reproduce:
Actual result:The "open gallery" button does not respond to taps on the device. images_pixel.mp4Expected result:The gallery should open when the "Open gallery" button is tapped |
a6a261d
to
d45d79e
Compare
@VladimrLitvinenko that's kind of expected outcome as a number of libs was affected. looking into it. Thanks |
d45d79e
to
02272f0
Compare
@VladimrLitvinenko both issues should be fixed now though I don't have a device to check the second one |
7eb3cb7
to
7763f9f
Compare
79% of end-end tests have passed
Not executed tests (2)Failed tests (7)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Passed tests (27)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
7763f9f
to
2fba9da
Compare
@rasom That's strange, but it seems that the issue has disappeared. I have tested it on the latest nightly build and the issue is no longer present. Additionally, other members of the QA team who are using Android 13 have also verified that the issue is resolved. Based on this, it appears that there is no need to merge this PR anymore.. |
@VladimrLitvinenko that doesn't make too much sense as the issue is not imaginary and actually logged in react-native-mail repo chirag04/react-native-mail#196, and we do have an old version of that lib in develop. On the other hand I'm happy to stop working on it and we can just wait till it will pop up again :) |
fix #16251
statue: wip