Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Give non-destructive instructions when Keycard migration failed #21844

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

shivekkhurana
Copy link
Contributor

This PR adds #21816 back to develop. The original PR was merged to release branch directly.

@shivekkhurana shivekkhurana self-assigned this Dec 18, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Dec 18, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cfaa861 #1 2024-12-18 15:49:03 ~4 min tests 📄log
✔️ cfaa861 #1 2024-12-18 15:51:14 ~7 min android-e2e 🤖apk 📲
✔️ cfaa861 #1 2024-12-18 15:52:15 ~7 min ios 📱ipa 📲
✔️ cfaa861 #1 2024-12-18 15:52:24 ~8 min android 🤖apk 📲

@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 0
Passed tests: 8

Passed tests (8)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

@mariia-skrypnyk mariia-skrypnyk self-assigned this Dec 19, 2024
@mariia-skrypnyk
Copy link

Hey @shivekkhurana !

Thanks for PR!
I've made a release build from this PR build and checked fix on Android.
Works fine except of small UI issues which I will report separately.
E2E looks great.

PR can be merged.

@shivekkhurana shivekkhurana merged commit a85ca5b into develop Dec 20, 2024
6 checks passed
@shivekkhurana shivekkhurana deleted the shivekkhurana/bring-21816-to-develop branch December 20, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

6 participants