Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-boarding: re add bio-metric screen to syncing flow #21890

Merged
merged 1 commit into from
Jan 9, 2025
Merged

On-boarding: re add bio-metric screen to syncing flow #21890

merged 1 commit into from
Jan 9, 2025
+45 −195

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Jan 7, 2025 •
edited
Loading

leftover from #21884 (comment)

Video

signal-2025-01-08-172823.mp4

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Jan 7, 2025 •
edited
Loading

Jenkins Builds

Click to see older builds (27)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0f19aea #1 2025-01-07 09:42:13 ~5 min tests 📄log
✔️ 0f19aea #1 2025-01-07 09:43:34 ~6 min android-e2e 🤖apk 📲
✔️ 0f19aea #1 2025-01-07 09:43:52 ~6 min ios 📱ipa 📲
✔️ 0f19aea #1 2025-01-07 09:46:13 ~9 min android 🤖apk 📲
✔️ 21cfea1 #2 2025-01-08 09:28:56 ~4 min tests 📄log
✔️ 21cfea1 #2 2025-01-08 09:31:33 ~6 min android 🤖apk 📲
❌ f64098a #3 2025-01-08 09:34:37 ~2 min tests 📄log
✔️ f64098a #3 2025-01-08 09:38:36 ~6 min android 🤖apk 📲
✔️ f64098a #3 2025-01-08 09:39:07 ~7 min android-e2e 🤖apk 📲
✔️ f64098a #3 2025-01-08 09:39:13 ~7 min ios 📱ipa 📲
✔️ 2e72d45 #4 2025-01-08 10:03:50 ~4 min tests 📄log
✔️ 2e72d45 #4 2025-01-08 10:05:41 ~6 min android-e2e 🤖apk 📲
✔️ 2e72d45 #4 2025-01-08 10:05:54 ~6 min ios 📱ipa 📲
✔️ 2e72d45 #4 2025-01-08 10:07:20 ~7 min android 🤖apk 📲
✔️ ffb0600 #5 2025-01-08 11:38:33 ~4 min tests 📄log
✔️ ffb0600 #5 2025-01-08 11:40:48 ~6 min ios 📱ipa 📲
✔️ ffb0600 #5 2025-01-08 11:41:15 ~6 min android 🤖apk 📲
✔️ ffb0600 #5 2025-01-08 11:41:39 ~7 min android-e2e 🤖apk 📲
✔️ 90e9e24 #6 2025-01-08 11:52:24 ~4 min tests 📄log
✔️ 90e9e24 #6 2025-01-08 11:55:52 ~7 min android-e2e 🤖apk 📲
✔️ 90e9e24 #6 2025-01-08 11:55:59 ~7 min ios 📱ipa 📲
✔️ 90e9e24 #6 2025-01-08 11:56:33 ~8 min android 🤖apk 📲
✔️ 3e51bd0 #7 2025-01-08 12:03:48 ~4 min tests 📄log
✔️ 6bfdd7e #10 2025-01-08 12:12:42 ~4 min tests 📄log
✔️ 6bfdd7e #10 2025-01-08 12:14:26 ~6 min ios 📱ipa 📲
✔️ 6bfdd7e #10 2025-01-08 12:16:39 ~8 min android-e2e 🤖apk 📲
✔️ 6bfdd7e #10 2025-01-08 12:16:51 ~8 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4d8e0ff #11 2025-01-09 11:25:14 ~4 min tests 📄log
✔️ 4d8e0ff #11 2025-01-09 11:27:27 ~6 min ios 📱ipa 📲
✔️ 4d8e0ff #11 2025-01-09 11:29:09 ~8 min android-e2e 🤖apk 📲
✔️ 4d8e0ff #11 2025-01-09 11:29:36 ~9 min android 🤖apk 📲
✔️ 7086a6f #12 2025-01-09 12:47:23 ~4 min tests 📄log
✔️ 7086a6f #12 2025-01-09 12:49:08 ~6 min ios 📱ipa 📲
✔️ 7086a6f #12 2025-01-09 12:51:21 ~8 min android-e2e 🤖apk 📲
✔️ 7086a6f #12 2025-01-09 12:51:49 ~9 min android 🤖apk 📲

@Parveshdhull Parveshdhull mentioned this pull request Jan 7, 2025
Merged
@Parveshdhull Parveshdhull self-assigned this Jan 7, 2025
@Parveshdhull Parveshdhull force-pushed the fix/syncing-flow-biometric-navigation branch 5 times, most recently from 90e9e24 to 3e51bd0 Compare January 8, 2025 11:58
Parveshdhull
Parveshdhull commented Jan 8, 2025
View reviewed changes
src/status_im/contexts/onboarding/syncing/progress/view.cljs
:customization-color profile-color
:size 40
:on-press #(try-again logged-in?)}}])
(let [two-vertical-actions-height 116]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New change - other are indentations - leftover from #21884 (comment)

@Parveshdhull Parveshdhull force-pushed the fix/syncing-flow-biometric-navigation branch 2 times, most recently from 9bf01cb to dfa7d7f Compare January 8, 2025 12:05
@Parveshdhull Parveshdhull changed the title [WIP] On-boarding: re add bio-metric screen to syncing flow On-boarding: re add bio-metric screen to syncing flow Jan 8, 2025
@Parveshdhull Parveshdhull marked this pull request as ready for review January 8, 2025 12:07
@Parveshdhull Parveshdhull force-pushed the fix/syncing-flow-biometric-navigation branch from dfa7d7f to 6bfdd7e Compare January 8, 2025 12:07
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 1
Expected to fail tests: 0
Passed tests: 7

IDs of failed tests: 703133

Failed tests (1)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133

    Device 1: Tap on found: Button
    # STEP: Check that removed user is not shown in the list anymore

    critical/chats/test_public_chat_browsing.py:240: in test_restore_multiaccount_with_waku_backup_remove_profile_switch
    self.errors.verify_no_errors()
base_test_case.py:176: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!



    Device sessions

    Passed tests (7)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    ilmotta
    ilmotta approved these changes Jan 8, 2025
    View reviewed changes
    Copy link
    Contributor

    @ilmotta ilmotta left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks @Parveshdhull. Works well from my tests.

    @status-im-auto
    Copy link
    Member

    75% of end-end tests have passed

    Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6

    IDs of failed tests: 727231,740490

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231 
    Test setup failed: critical/test_wallet.py:223: in prepare_devices
    self.sender_username = self.home_view.get_username()
../views/home_view.py:528: in get_username
    profile_view.default_username_text.wait_for_element(3)
../views/base_element.py:128: in wait_for_element
    raise TimeoutException(
 Device `1`: `Text` by` accessibility id`: `username` is not found on the screen after wait_for_element



    2. test_wallet_balance_mainnet, id: 740490

    Device 1: Click until Text by accessibility id: username will be presented
    Device 1: Find ProfileButton by accessibility id: open-profile 

    Test setup failed: critical/test_wallet.py:223: in prepare_devices
    self.sender_username = self.home_view.get_username()
../views/home_view.py:528: in get_username
    profile_view.default_username_text.wait_for_element(3)
../views/base_element.py:128: in wait_for_element
    raise TimeoutException(
 Device `1`: `Text` by` accessibility id`: `username` is not found on the screen after wait_for_element



    Passed tests (6)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    @Horupa-Olena Horupa-Olena self-assigned this Jan 9, 2025
    @Horupa-Olena Horupa-Olena force-pushed the fix/syncing-flow-biometric-navigation branch from 6bfdd7e to 4d8e0ff Compare January 9, 2025 11:20
    @Horupa-Olena
    Copy link

    @Parveshdhull Thank you for your PR! Everything works well, and the PR can be merged.

    @Parveshdhull Parveshdhull force-pushed the fix/syncing-flow-biometric-navigation branch from 4d8e0ff to 7086a6f Compare January 9, 2025 12:42
    @Parveshdhull Parveshdhull merged commit 874aa98 into develop Jan 9, 2025
    5 checks passed
    @Parveshdhull Parveshdhull deleted the fix/syncing-flow-biometric-navigation branch January 9, 2025 12:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ulisesmac ulisesmac ulisesmac approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    Assignees

    @Parveshdhull Parveshdhull

    @Horupa-Olena Horupa-Olena

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Status: DONE
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @Parveshdhull @status-im-auto @Horupa-Olena @ilmotta @ulisesmac