Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21652] The main part of a backup flow is missing at Keycard migrati… #21893

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

flexsurfer
Copy link
Member

fixes #21652

QA: please also check new keypair creation in the wallet

@status-im-auto
Copy link
Member

status-im-auto commented Jan 7, 2025

Jenkins Builds

Click to see older builds (5)
Commit #️⃣ Finished (UTC) Duration Platform Result
cf68b04 #1 2025-01-07 13:25:49 ~2 min tests 📄log
✔️ 4b20227 #2 2025-01-07 13:34:24 ~4 min tests 📄log
✔️ 4b20227 #2 2025-01-07 13:36:58 ~7 min android 🤖apk 📲
✔️ 4b20227 #2 2025-01-07 13:37:07 ~7 min ios 📱ipa 📲
✔️ 4b20227 #2 2025-01-07 13:37:36 ~7 min android-e2e 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 628b671 #3 2025-01-09 10:04:29 ~4 min tests 📄log
✔️ 628b671 #3 2025-01-09 10:06:34 ~6 min android-e2e 🤖apk 📲
✔️ 628b671 #3 2025-01-09 10:07:33 ~7 min ios 📱ipa 📲
✔️ 628b671 #3 2025-01-09 10:07:55 ~8 min android 🤖apk 📲
✔️ 3870c3b #4 2025-01-09 11:02:05 ~4 min tests 📄log
✔️ 3870c3b #4 2025-01-09 11:04:01 ~6 min android-e2e 🤖apk 📲
✔️ 3870c3b #4 2025-01-09 11:05:01 ~7 min ios 📱ipa 📲
✔️ 3870c3b #4 2025-01-09 11:05:45 ~8 min android 🤖apk 📲

Copy link
Member

@seanstrom seanstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅

Left one small comment about how the UI may change wallet-UX, but I'm not sure.

Comment on lines +100 to 130
{:icon-name :i/close
:on-press #(rf/dispatch [:navigate-back])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change affect the wallet UX? For example, does the wallet-flow for backing up the seed-phrase still need a back-arrow?

cc @smohamedjavid

Copy link
Member Author

@flexsurfer flexsurfer Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was wrong before, it's modal but it had back arrow, so it's fixed now

@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 0
Passed tests: 8

Passed tests (8)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

@mariia-skrypnyk mariia-skrypnyk self-assigned this Jan 8, 2025
@mariia-skrypnyk
Copy link

Hi @flexsurfer !

As we have changes in design it would be great if we ad these parts to our keycard migration backup flow:

1) restriction to make a screenshot

Screenshot 2025-01-09 at 09 06 26

2) Complete backup drawer

Screenshot 2025-01-09 at 09 12 58

3) Verify your backup drawer

Screenshot 2025-01-09 at 09 05 45

https://www.figma.com/design/YGm3igIOAcwMqUVJWCJ6f1/Keycard?node-id=3395-33010&m=dev

This flow relates specifically to the keycard functionality. At the moment, the create account flow is outdated and awaiting an update.

@flexsurfer flexsurfer force-pushed the feature/The-main-part-of-a-backup-flow-is-missing-at-Keycard-migration-flow-and-Create-User-flow-#21652 branch from 4b20227 to 628b671 Compare January 9, 2025 09:59
@flexsurfer
Copy link
Member Author

thanks @mariia-skrypnyk 2 - fixed, please make separate tasks for 1 and 3

@mariia-skrypnyk
Copy link

Hey @flexsurfer !

Please, fix 2 small issues:

  1. there is a typo in design, we need to use "recovery phrase"
  2. text should not exceed the boarder
Screenshot 2025-01-09 at 11 38 00 Screenshot 2025-01-09 at 11 35 52

@flexsurfer
Copy link
Member Author

thanks @mariia-skrypnyk 1 fixed , for 2 pls create follow up because it seems like it's a different component we need to create or fix current component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: IN TESTING
Development

Successfully merging this pull request may close these issues.

The main part of a backup flow is missing at Keycard migration flow and Create User flow
6 participants