Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray API and refactor blas/ext/base/dsnansum #3268

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: add C ndarray API and refactor blas/ext/base/dsnansum #3268

wants to merge 3 commits into from

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • add C ndarray API and refactor/cleanup blas/ext/base/dsnansumpw

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 26, 2024
@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Nov 26, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 26, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsnansum $\color{green}345/345$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}345/345$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

headlessNode
headlessNode commented Nov 26, 2024
View reviewed changes
lib/node_modules/@stdlib/blas/ext/base/dsnansum/benchmark/benchmark.js
@@ -22,7 +22,7 @@

var bench = require( '@stdlib/bench' );
var bernoulli = require( '@stdlib/random/base/bernoulli' );
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
var uniform = require( '@stdlib/random/base/uniform' );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgryte This change is based on how random numbers are generated in other similar packages i.e. dsnansumors and dsnansumpw.

@headlessNode headlessNode marked this pull request as ready for review November 26, 2024 18:52
@headlessNode headlessNode mentioned this pull request Nov 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@headlessNode @stdlib-bot