Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add findIndex method to array/fixed-endian-factory #3274

Closed
wants to merge 64 commits into from

Conversation

pranav-1720
Copy link
Contributor

@pranav-1720 pranav-1720 commented Nov 27, 2024

Resolves #3142

Description

What is the purpose of this pull request?

  • Adds findIndex method to array/fixed-endian-factory
  • Add tests for the respective method
  • Add benchmarks files for the respective method
  • Updates README for fixed-endian-factory for the respective method

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

pranav-1720 and others added 30 commits November 24, 2024 06:59
PR-URL: stdlib-js#3211
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3030
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#2994
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#3200
Closes: stdlib-js#3138
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3163
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3203
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3204
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Muhammad Haris <[email protected]>
Reviewed-by: Aman Bhansali <[email protected]>
Signed-off-by: Snehil Shah <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#3223

Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2739
Ref: stdlib-js#2647

Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Signed-off-by: Snehil Shah <[email protected]>
…as/ext/base/dapxsumkbn2`

PR-URL: stdlib-js#3227

Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3233

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
PR-URL: stdlib-js#3225

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>
PR-URL: stdlib-js#3240

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: stdlib-bot <[email protected]>
Planeshifter and others added 25 commits November 25, 2024 18:33
PR-URL: stdlib-js#3196
Closes: stdlib-js#3179
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3207
Closes: stdlib-js#3177
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Vinit Pandit <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: Abhijit <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#3258
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: stdlib-bot <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3261
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: stdlib-bot <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3260
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: stdlib-bot <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
…as/ext/base/dnannsumors`

PR-URL: stdlib-js#3252
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>
PR-URL: stdlib-js#3228
Closes: stdlib-js#3164
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3208
Closes: stdlib-js#3176
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3200
Closes: stdlib-js#3138
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
@pranav-1720 pranav-1720 changed the title Find index feat: add findIndex method to array/fixed-endian-factory Nov 27, 2024
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}830/1089$
$\color{green}+76.22\%$
$\color{red}61/70$
$\color{green}+87.14\%$
$\color{red}13/24$
$\color{green}+54.17\%$
$\color{red}830/1089$
$\color{green}+76.22\%$

The above coverage report was generated for the changes in this PR.

@pranav-1720
Copy link
Contributor Author

HI, I do not have much experience with github so i was having trouble in editing the previous pull request for this issue. The changes i was making in my local machine were not getting pushed to my fork for some reason. I am not sure why it is showing commits from other users as well even though the changes to the file are limited to the findindex method of fixed-endian-factory.
Not sure what command to run to clean the git history. feedback on changes to be made or what git command to run to clean the histroy would be appreciated.

@adityacodes30
Copy link
Contributor

adityacodes30 commented Nov 27, 2024

maybe your branch history has diverged, if you dont have much exp with git your're better off just wiping the slate clean and reimplementing , the steps in contributing guidelines might help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.