-
-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add findIndex method to array/fixed-endian-factory #3274
Conversation
PR-URL: stdlib-js#3215 Reviewed-by: Philipp Burckhardt <[email protected]>
…al/croundf` PR-URL: stdlib-js#3217 Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3218 Closes: stdlib-js#3201 Reviewed-by: Athan Reines <[email protected]>
…ecial/cround` PR-URL: stdlib-js#3216 Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3197 Reviewed-by: Athan Reines <[email protected]> Co-authored-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#3211 Ref: stdlib-js#2039 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3030 Ref: stdlib-js#2039 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]> Co-authored-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#2994 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]> Co-authored-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#3200 Closes: stdlib-js#3138 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3163 Ref: stdlib-js#2039 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3203 Ref: stdlib-js#2039 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3204 Ref: stdlib-js#2039 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Muhammad Haris <[email protected]> Reviewed-by: Aman Bhansali <[email protected]> Signed-off-by: Snehil Shah <[email protected]> Co-authored-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#3223 Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2739 Ref: stdlib-js#2647 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Athan Reines <[email protected]> Signed-off-by: Snehil Shah <[email protected]>
…/ext/base/dapx` PR-URL: stdlib-js#3226 Reviewed-by: Philipp Burckhardt <[email protected]>
…as/ext/base/dapxsumkbn2` PR-URL: stdlib-js#3227 Reviewed-by: Philipp Burckhardt <[email protected]>
…cial/cphase` PR-URL: stdlib-js#3231 Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3233 Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Gunj Joshi <[email protected]>
PR-URL: stdlib-js#3225 Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>
PR-URL: stdlib-js#3240 Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#3246 Reviewed-by: Philipp Burckhardt <[email protected]>
This reverts commit 184d71f.
This reverts commit 97a27cf.
This reverts commit ac4992b.
This reverts commit cdaf16f.
PR-URL: stdlib-js#3196 Closes: stdlib-js#3179 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3198 Closes: stdlib-js#3180 Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3207 Closes: stdlib-js#3177 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Vinit Pandit <[email protected]> Signed-off-by: Athan Reines <[email protected]> Co-authored-by: Abhijit <[email protected]> Co-authored-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#3258 Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3261 Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3260 Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]>
…mpw` PR-URL: stdlib-js#3255 Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3254 Reviewed-by: Athan Reines <[email protected]>
…as/ext/base/dnannsumors` PR-URL: stdlib-js#3252 Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>
PR-URL: stdlib-js#3228 Closes: stdlib-js#3164 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3208 Closes: stdlib-js#3176 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3200 Closes: stdlib-js#3138 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
Coverage Report
The above coverage report was generated for the changes in this PR. |
HI, I do not have much experience with github so i was having trouble in editing the previous pull request for this issue. The changes i was making in my local machine were not getting pushed to my fork for some reason. I am not sure why it is showing commits from other users as well even though the changes to the file are limited to the findindex method of fixed-endian-factory. |
maybe your branch history has diverged, if you dont have much exp with git your're better off just wiping the slate clean and reimplementing , the steps in contributing guidelines might help |
Resolves #3142
Description
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers