Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bench: refactor random value generation #5465

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

bench: refactor random value generation #5465

wants to merge 5 commits into from

Conversation

saurabhraghuvanshii
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • refractor random number generation in math/base/special/binet*

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@saurabhraghuvanshii
bench: refactor random generation
fffb21d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 26, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 26, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/binet $\color{green}250/250$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}250/250$
$\color{green}+100.00\%$
math/base/special/binomcoef $\color{green}269/269$
$\color{green}+100.00\%$ 		$\color{green}34/34$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}269/269$
$\color{green}+100.00\%$
math/base/special/boxcox $\color{green}208/208$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}208/208$
$\color{green}+100.00\%$
math/base/special/boxcox1p $\color{green}232/232$
$\color{green}+100.00\%$ 		$\color{green}16/16$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}232/232$
$\color{green}+100.00\%$
math/base/special/boxcox1pinv $\color{green}224/224$
$\color{green}+100.00\%$ 		$\color{green}12/12$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}224/224$
$\color{green}+100.00\%$
math/base/special/boxcoxinv $\color{green}218/218$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}218/218$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte requested a review from anandkaranubc February 27, 2025 09:58
anandkaranubc
anandkaranubc suggested changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@anandkaranubc anandkaranubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR still requires a lot of changes in order to be merged.

@anandkaranubc anandkaranubc added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 1, 2025
@saurabhraghuvanshii
Merge branch 'stdlib-js:develop' into random-math1
2f4b4ae
@saurabhraghuvanshii
chore: updates values
acadf4b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: failed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 2, 2025
anandkaranubc
anandkaranubc reviewed Mar 2, 2025
View reviewed changes
lib/node_modules/@stdlib/math/base/special/boxcoxinv/benchmark/benchmark.js Outdated

x = uniform( 100, 0.0, 10.0 );
y = uniform( x.length, 0.0, 10.0 );
x = uniform( 100, 0, 10 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be x = uniform( 100, 0.0, 10.0 );

This would help:

https://github.com/aayush0325/stdlib/blob/71817278b22a8d65e0ff90f6425c7939a4ee6269/docs/contributing/FAQ.md#when-should-i-use-decimals-in-examples-benchmarks-and-documentation-and-when-should-i-avoid-them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is expected throughout the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing I don't understand when should I put .0 and when not It will be help full for me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I read it .

@saurabhraghuvanshii
Merge branch 'stdlib-js:develop' into random-math1
cfce2c1
@saurabhraghuvanshii
chore: update values
03eea81 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
anandkaranubc
anandkaranubc suggested changes Mar 4, 2025
View reviewed changes
lib/node_modules/@stdlib/math/base/special/boxcox/benchmark/benchmark.js
Comment on lines +38 to +39
x = uniform( 100, 1, 11 );
y = uniform( 100, 1, 11 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x = uniform( 100, 1, 11 );
y = uniform( 100, 1, 11 );
x = uniform( 100, 1.0, 11.0 );
y = uniform( 100, 1.0, 11.0 );

lib/node_modules/@stdlib/math/base/special/boxcox/benchmark/benchmark.native.js
Comment on lines +47 to +48
x = uniform( 100, 1, 11 );
y = uniform( 100, 1, 11 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandkaranubc anandkaranubc anandkaranubc requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saurabhraghuvanshii @stdlib-bot @anandkaranubc