codereview #1

stefanmcshane · 2022-10-20T02:19:49Z

No description provided.

…into v3/main

stefanmcshane · 2022-10-20T05:17:12Z

pkg/controllers/argocd.go

+	// Client argocdclient.
+}
+
+func NewArgoCDClient() (ArgoCD, error) {


Catchall function for now, which would be broken up into:

NewArgoCDClient() which takes the config required as a param and returns the client

Convenience functions for reading whatever data we need from the ArgoCD server

Release `porter-agent` to `v3`

abelanger5

This is awesome 💯

Left some minor comments for the moment where I noticed inconsistencies with how we're doing things elsewhere.

We'll definitely need some overall consolidation in the rest of the agent code (more explicitly naming of consumers/producers).

pkg/controllers/argocd_resource_hook_consumer.go

abelanger5 · 2022-10-23T17:44:57Z

api/server/handlers/argo/resource_hooks.go

+	}
+
+	err := h.ArgoCDResourceConsumer.Consume(r.Context(), req)
+	if err != nil {


We use the apierrors package from porter to ensure consistent logging/formatting of internal errors -- see here for reference.

Add `namespace` to query for `pod_values`

Co-authored-by: abelanger5 <[email protected]>

stefanmcshane · 2022-10-24T17:15:38Z

TODO:

Enable auto-sync on any requests
Disable auto-sync on any rollback requests

abelanger5 and others added 30 commits September 26, 2022 15:11

create initial boilerplate for agent v3

51fbc15

add v3 DB ops and packages

5ab4107

add log and event DB ops

074d116

no logs in the DB

763e9c2

add api and cli packages and base code

af891ba

add event cache DB ops

3a25114

add test fixtures and implement core of incident detection algorithm

e6edb22

Merge branch 'v3/main' of https://github.com/porter-dev/porter-agent …

127e8ff

…into v3/main

update models and incident detection

df6015f

delete an hour old event cache entries from the DB

5ecef82

fix query

865a1ef

add some more logging

edd926a

feat: add support for memorystore

c998c15

chore: minor fix

918574f

chore: make logs dir configurable

7ad15e0

chore: make permission to 0600

c534da7

chore: use v3/main

2d520b7

add tighter repository integration to detector, remove unused packages

94505e3

fix merge conflicts

1b3ea8a

rfac: remove stop method and make stream channel controllable

851da47

add filter options

3e8ae47

incident handler base

297979b

add resolver mechanism

7c6d75c

Merge branch 'v3/main' of https://github.com/porter-dev/porter-agent …

39a0903

…into v3/main

integrate with new incident repository methods

627171f

add incident de-dup logic

dbdc47a

finalize integration with alerter and fix edge cases

506b199

Update memorystore.go

ca5a14f

Merge branch 'v3/main' into feat/logstore

008fb5c

add event handler

75bdd40

abelanger5 and others added 4 commits October 19, 2022 15:56

fix cache hit logic

b6ffcda

add some debug lines

d85d716

add job cache to schema migration

47ead2b

pushing for now

1fbec12

stefanmcshane changed the base branch from main to v3/main October 20, 2022 02:20

stefanmcshane added 2 commits October 20, 2022 01:13

updated readme

96a93e8

removed key from notification trigger

58b70ed

stefanmcshane commented Oct 20, 2022

View reviewed changes

abelanger5 and others added 10 commits October 20, 2022 09:11

make sure we don't alert on events older than 1 hour

3e43046

handle image pull error timestamp issue

8b696bd

fix print for float 2

7743307

generate separate incidents for separate job runs

9c7bf43

improve logic for resolving critical incidents

3fa15d7

remove debug lines

d729200

add livez and readyz handlers

1339b05

Merge pull request #27 from porter-dev/v3/main

60b0d69

Release `porter-agent` to `v3`

working ingestion engine

54cca98

working ingestion engine

555f5d7

abelanger5 reviewed Oct 23, 2022

View reviewed changes

abelanger5 and others added 7 commits October 23, 2022 15:20

add namespace to pod values query options

0b97af1

add namespace to api request type

1007607

Merge pull request #28 from porter-dev/belanger/add-ns-to-values-query

e5d82b1

Add `namespace` to query for `pod_values`

pass namespace selector through pod values and fix length check

7295cc3

Update pkg/controllers/argocd_resource_hook_consumer.go

4c08899

Co-authored-by: abelanger5 <[email protected]>

fixing conflicts

b9733c0

address pr concerns

6057e72

stefanmcshane changed the base branch from v3/main to main October 24, 2022 14:14

stefanmcshane added 2 commits October 24, 2022 16:00

added mocks and controller test

6d541c4

added sync and rollback

084946d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

codereview #1

codereview #1

stefanmcshane commented Oct 20, 2022

stefanmcshane Oct 20, 2022

abelanger5 left a comment

abelanger5 Oct 23, 2022

stefanmcshane commented Oct 24, 2022 •

edited

Loading

codereview #1

Are you sure you want to change the base?

codereview #1

Conversation

stefanmcshane commented Oct 20, 2022

stefanmcshane Oct 20, 2022

Choose a reason for hiding this comment

abelanger5 left a comment

Choose a reason for hiding this comment

abelanger5 Oct 23, 2022

Choose a reason for hiding this comment

stefanmcshane commented Oct 24, 2022 • edited Loading

stefanmcshane commented Oct 24, 2022 •

edited

Loading