Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create da-DA.json #67

Closed
wants to merge 1 commit into from
Closed

Create da-DA.json #67

wants to merge 1 commit into from

Conversation

martin-ro
Copy link
Contributor

Adds Denmark country data

Description

Adds Denmark country data

Motivation and context

Adds missing country

How has this been tested?

n/a

Screenshots (if appropriate)

n/a

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • I ran tests locally with composer test:coverage and it passed.
  • If my change requires a change to the documentation, I have updated it accordingly.

Adds Denmark country data
@martin-ro martin-ro closed this Oct 23, 2024
@stefro
Copy link
Owner

stefro commented Oct 23, 2024

Hi @martin-ro, thank you for your contribution, but you've closed the PR before I was able to merge it. Is there any reason for that? Or was this maybe a mistake?

@martin-ro
Copy link
Contributor Author

martin-ro commented Oct 23, 2024

I forgot to add the language in the config file. I have created a new PR with the language added to the config here: #68

@stefro
Copy link
Owner

stefro commented Oct 23, 2024

Ah, I see now! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants