Network Settings - Soroban RPC URL #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristidesstaffieri
changed the title
| @@ -105,3 +106,23 @@ export const migrateFriendBotUrlNetworkDetails = async () => { | |||
|
|
|||
| await localStore.setItem(NETWORKS_LIST_ID, migratedNetworkList); | |||
| }; | |||
|
|
|||
| export const migrateSorobanRpcUrlNetworkDetails = async () => { | |||
There was a problem hiding this comment.
We'll have to do this again once we support Soroban in testnet/pubnet
piyalbasu
reviewed
Sep 8, 2023
| return true | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
very NIT: but this would be a little tidier as const supportsSorobanRpc = (network: string) => network === NETWORK_NAMES.FUTURENET
There was a problem hiding this comment.
oh yeah for sure 😄
There was a problem hiding this comment.
done in 704bac5
piyalbasu
reviewed
Sep 8, 2023
|
|
||
| if (!sorobanClient.server || !sorobanClient.newTxBuilder) { | ||
| throw new Error("soroban rpc not supported") | ||
| } |
There was a problem hiding this comment.
is it better to throw this error in SorobanContext so we don't have to do this check every time we try to use sorobanClient?
There was a problem hiding this comment.
well we can't throw it there because there is no way to instantiate a SorobanClient on pubnet/testnet yet so we had to move to an optional server/tx builder in order to allow custom ones as well as support some default networks but not all of them.
There was a problem hiding this comment.
this was sort of overlooked before because we incorrectly passed in a horizon instance when we were on pubnet/testnet.
piyalbasu
approved these changes
Sep 13, 2023
piyalbasu
added a commit
that referenced
this pull request
Sep 13, 2023
* Updated onboarding last steps (#955) * Functional, needs styling * Use proper apostrophe * Network Settings - Soroban RPC URL (#953) * renames url field in network settings, adds soroban rpc url field * adds handling for optional soroban rpc support * also config custom soroban rpcs * refactor helper to be more concise * Added translations --------- Co-authored-by: Iveta <[email protected]> Co-authored-by: aristides <[email protected]>
aristidesstaffieri
added a commit
that referenced
this pull request
Sep 14, 2023
* renames url field in network settings, adds soroban rpc url field * adds handling for optional soroban rpc support * also config custom soroban rpcs * Updated onboarding last steps (#955) * Functional, needs styling * Use proper apostrophe * refactor helper to be more concise * refactors storage getter/setter to account for networks for token id lists * Network Settings - Soroban RPC URL (#953) * renames url field in network settings, adds soroban rpc url field * adds handling for optional soroban rpc support * also config custom soroban rpcs * refactor helper to be more concise * adds migration to network keyed toke id list * Bump versions to 5.4.0 (#960) * docs(): bumping release to 5.4.0 * Empty-Commit --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Piyal Basu <[email protected]> * refactors to a network keyed object of token IDs for token id list * fixes migration to be backwards compatible * adds storage version and uses storage version in token id list migration * fix typo in storage key * hardcode storage schema version, decouple from package version * updates comment for version migration --------- Co-authored-by: Iveta <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Piyal Basu <[email protected]>
piyalbasu
added a commit
that referenced
this pull request
Sep 16, 2023
* adds the bump footprint expiration op type to tx history * WIP, refactors history item to build async rows * clean up and organize soroban related helpers * Added translations * remove unwanted files from translations commit * removes helper shim and fixes import pattern * use sdk base fee, add restore footprint header title, use more direct i128 helper * fixes soroban tx submission error handling, bumps soroban-client * fix use of source account in SorobanContext newTxBuilder * split transfer and mint history items * Added translations * WIP, adds base states for testing soroban token payment * adds mock soroban context, tests token payment flow * adds tests for soroban helpers * adds token amount dom test * adds new path for signing auth entries, adds SignAuthEntry component and related API hooks * Adds basic signing component for auth entry sign flow * Adds new external api signAuthEntry, adds docs, adds sign auth entry component * Added translations * adds buildInvocationTree to render formatted json for invocations and sub invocations * use correct key in responseQueue handler for signAuthEntry, clean up AuthEntry * splits SignTx and SignBlob, makes new route for sign-blob * use buildInvocationTree in transaction render for signTx * Added translations * Added translations * remove accidental tarball commit * adds missing loading states, fixes missing error handling in message handler * remove extra line * refactors signing flows to use a common helper hook * dont allow HW signing on sign blob or sign auth entry, not currently supported in ledger API * Added translations * Added translations * updates HW wallet not supported text * Added translations * refactors SorobanContext to accoutn for missing rpc urls * moves dispatch to be in shared signing hook * add translations * Release/5.6.0 (#954) * Updated onboarding last steps (#955) * Functional, needs styling * Use proper apostrophe * Network Settings - Soroban RPC URL (#953) * renames url field in network settings, adds soroban rpc url field * adds handling for optional soroban rpc support * also config custom soroban rpcs * refactor helper to be more concise * Added translations --------- Co-authored-by: Iveta <[email protected]> Co-authored-by: aristides <[email protected]> * Refactor/multi network custom token (#958) * renames url field in network settings, adds soroban rpc url field * adds handling for optional soroban rpc support * also config custom soroban rpcs * Updated onboarding last steps (#955) * Functional, needs styling * Use proper apostrophe * refactor helper to be more concise * refactors storage getter/setter to account for networks for token id lists * Network Settings - Soroban RPC URL (#953) * renames url field in network settings, adds soroban rpc url field * adds handling for optional soroban rpc support * also config custom soroban rpcs * refactor helper to be more concise * adds migration to network keyed toke id list * Bump versions to 5.4.0 (#960) * docs(): bumping release to 5.4.0 * Empty-Commit --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Piyal Basu <[email protected]> * refactors to a network keyed object of token IDs for token id list * fixes migration to be backwards compatible * adds storage version and uses storage version in token id list migration * fix typo in storage key * hardcode storage schema version, decouple from package version * updates comment for version migration --------- Co-authored-by: Iveta <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Piyal Basu <[email protected]> * add prettier changes * Added translations * WIP: upgrade soroban-client (#961) * upgrade soroban-client * updates to new simulation response (#962) * updates to new simulation response * formatting tweaks * fix broken tests --------- Co-authored-by: Piyal Basu <[email protected]> --------- Co-authored-by: aristides <[email protected]> * move schema update * fix migration key * rm log * fix account history --------- Co-authored-by: Aristides Staffieri <[email protected]> Co-authored-by: Iveta <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]>
|
Hello. What is the difference between normal horizon and this soroban rpc? ( I don't have access to those links) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://stellarorg.atlassian.net/jira/software/c/projects/WAL/boards/61?modal=detail&selectedIssue=WAL-1077&assignee=63bc81730a1b5442166a2f79
Also fixes: https://stellarorg.atlassian.net/browse/WAL-1083
Renames
URLfield in network settings toHorizon RPC URLAdds
Soroban RPC URLfield to network settingsUpdates network settings in storage to support optional
sorobanRpcUrlUses new
sorobanRpcUrlfield to replace hardcoded soroban rpc url throughoutMigrates Network details to add
sorobanRpcUrlAdds handling for optional
sorobanRpcUrl