Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ingest/change Change struct to always pass LCM if available #5578

Open
chowbao opened this issue Jan 22, 2025 · 0 comments
Open
Labels
cdp-horizon-scrum ingest New ingestion system

Comments

@chowbao
Copy link
Contributor

chowbao commented Jan 22, 2025

The ingest/change Change struct has a field for Ledger *xdr.LedgerCloseMeta found here

It is not always populated depending on the Change.Reason (because LCM can be populated inside the change.Transaction). I believe it is more beneficial to always populate Change.Ledger no matter the change reason as it will always be able to be associated with a LedgerCloseMeta.

Supplementally we should evaluate whether or not it makes sense to always propagate OperationIndex and Transaction as well if they exist. This will depend on if they are only available for their correlated Change.Reason or if their current scope is not all inclusive of valid OperationIndex/Transaction data

Edit: OperationIndex and Transaction are always populated when relevant as it is already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cdp-horizon-scrum ingest New ingestion system
Projects
Status: To Do
Development

No branches or pull requests

2 participants