-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass through change updates to change compactor #304
Conversation
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
One other important note. This requires a schema change for the raw tables. I think it'd be worthwhile to have this run in the test airflow over the weekend if possible |
Yup, agreed. I also think we should modify the dune exports and drop these new columns and determine whether or not it's necessary to propagate into dune. If our end goal is to create a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, i didn't review the golden files and just assume they implicitly work based on tests passing
PR Checklist
PR Structure
otherwise).
Thoroughness
Release planning
semver, and I've changed the name of the BRANCH to major/_ , minor/_ or patch/* .
What
Github issue
Moving a copied version of the changeCompactor with the new Change struct fields into stellar-etl to pass through transaction_id, operation_id, and operation_type to ledger entry changes
Why
To get more useful join keys in the ledger entry change tables in BQ
Known limitations