Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types to conform to the new diagnostic event fields. #62

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Update types to conform to the new diagnostic event fields. #62

merged 2 commits into from
Mar 30, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Mar 29, 2023

This adds the diagnostic event type and the []events field to the simulateTransaction() response.

Closes #59.

paulbellamy
paulbellamy approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@paulbellamy paulbellamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that we should add a string enum type ("system" | "contract" | "diagnostic") for the event filters. As a form of documentation. But LGTM either way.

@Shaptic
Copy link
Contributor Author

Shaptic commented Mar 30, 2023

Great idea! Done.

@Shaptic Shaptic merged commit cb97d6d into main Mar 30, 2023
@Shaptic Shaptic deleted the diagnostic-events branch March 30, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbellamy paulbellamy paulbellamy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for smart contract diagnostic events
2 participants
@Shaptic @paulbellamy