update name from hardWalletSigners to hardWalletSigs

stellar · Jun 5, 2024 · 908cac9 · 908cac9
1 parent dcc93c4
commit 908cac9
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 19 deletions.
diff --git a/src/app/(sidebar)/transaction/sign/components/Overview.tsx b/src/app/(sidebar)/transaction/sign/components/Overview.tsx
@@ -92,13 +92,13 @@ export const Overview = () => {
     txXdr: string,
     signers: string[],
     networkPassphrase: string,
-    hardWalletSigners?: xdr.DecoratedSignature[],
+    hardWalletSigs?: xdr.DecoratedSignature[],
   ) => {
     const { xdr, message } = transactionSigner.signTx({
       txXdr,
       signers,
       networkPassphrase,
-      hardWalletSigners,
+      hardWalletSigs,
     });
 
     if (xdr && message) {
@@ -270,7 +270,7 @@ export const Overview = () => {
                   <Button
                     disabled={
                       (!HAS_SECRET_KEYS || HAS_INVALID_SECRET_KEYS) &&
-                      !sign.hardWalletSigners?.length
+                      !sign.hardWalletSigs?.length
                     }
                     size="md"
                     variant="secondary"
@@ -279,7 +279,7 @@ export const Overview = () => {
                         sign.importXdr,
                         secretInputs,
                         network.passphrase,
-                        sign.hardWalletSigners,
+                        sign.hardWalletSigs,
                       )
                     }
                   >

diff --git a/src/app/(sidebar)/transaction/sign/components/SignWithLedger.tsx b/src/app/(sidebar)/transaction/sign/components/SignWithLedger.tsx
@@ -29,7 +29,7 @@ export const SignWithLedger = ({
   setSignSuccess: Dispatch<SetStateAction<boolean>>;
 }) => {
   const { network, transaction } = useStore();
-  const { sign, updateSignedTx, updateHardWalletSigners } = transaction;
+  const { sign, updateSignedTx, updateHardWalletSigs } = transaction;
 
   const [isLoading, setIsLoading] = useState<boolean>(false);
 
@@ -69,9 +69,10 @@ export const SignWithLedger = ({
         .getPublicKey(sign.bipPath)
         .then((result: { publicKey: string }) => (publicKey = result.publicKey))
         .then(() => {
-          if (isHash) {
-            return ledgerApi.signHash(sign.bipPath, transaction.hash());
-          }
+          // @TODO waiting on design
+          // if (isHash) {
+          //   return ledgerApi.signHash(sign.bipPath, transaction.hash());
+          // }
           return ledgerApi.signTransaction(
             sign.bipPath,
             transaction.signatureBase(),
@@ -85,7 +86,7 @@ export const SignWithLedger = ({
           const hint = keyPair.signatureHint();
           const decorated = new xdr.DecoratedSignature({ hint, signature });
 
-          updateHardWalletSigners([decorated]);
+          updateHardWalletSigs([decorated]);
           setSignSuccess(true);
         })
         .catch(onError);

diff --git a/src/app/(sidebar)/transaction/sign/components/SignWithTrezor.tsx b/src/app/(sidebar)/transaction/sign/components/SignWithTrezor.tsx
@@ -28,7 +28,7 @@ export const SignWithTrezor = ({
   setSignSuccess: Dispatch<SetStateAction<boolean>>;
 }) => {
   const { network, transaction } = useStore();
-  const { sign, updateSignedTx, updateHardWalletSigners } = transaction;
+  const { sign, updateSignedTx, updateHardWalletSigs } = transaction;
 
   const [isLoading, setIsLoading] = useState<boolean>(false);
 
@@ -67,7 +67,7 @@ export const SignWithTrezor = ({
         const hint = keyPair.signatureHint();
         const decorated = new xdr.DecoratedSignature({ hint, signature });
 
-        updateHardWalletSigners([decorated]);
+        updateHardWalletSigs([decorated]);
         setSignSuccess(true);
       } else {
         const errorPayload = trezorResponse.payload as { error: string };

diff --git a/src/helpers/transactionSigner.ts b/src/helpers/transactionSigner.ts
@@ -6,12 +6,12 @@ const signTx = ({
   txXdr,
   signers,
   networkPassphrase,
-  hardWalletSigners,
+  hardWalletSigs,
 }: {
   txXdr: string;
   signers: string[];
   networkPassphrase: string;
-  hardWalletSigners?: xdr.DecoratedSignature[];
+  hardWalletSigs?: xdr.DecoratedSignature[];
 }) => {
   const validSecretKeys = [];
   const validPreimages = [];
@@ -53,7 +53,7 @@ const signTx = ({
     addedSigs++;
     newTx.signHashX(Buffer.from(signer, "hex"));
   });
-  hardWalletSigners?.forEach((signer) => {
+  hardWalletSigs?.forEach((signer) => {
     addedSigs++;
     newTx.signatures.push(signer);
   });

diff --git a/src/store/createStore.ts b/src/store/createStore.ts
@@ -91,7 +91,7 @@ export interface Store {
       importXdr: string;
       signedTx: string;
       bipPath: string;
-      hardWalletSigners: xdr.DecoratedSignature[] | undefined;
+      hardWalletSigs: xdr.DecoratedSignature[] | undefined;
     };
     // TODO: update as needed
     // simulate: AnyObject;
@@ -120,7 +120,7 @@ export interface Store {
     updateSignImportXdr: (xdr: string) => void;
     updateSignedTx: (tx: string) => void;
     updateBipPath: (bipPath: string) => void;
-    updateHardWalletSigners: (signer: xdr.DecoratedSignature[]) => void;
+    updateHardWalletSigs: (signer: xdr.DecoratedSignature[]) => void;
     resetSign: () => void;
   };
 }
@@ -165,7 +165,7 @@ const initTransactionState = {
     importXdr: "",
     signedTx: "",
     bipPath: "",
-    hardWalletSigners: undefined,
+    hardWalletSigs: undefined,
   },
 };
 
@@ -333,9 +333,9 @@ export const createStore = (options: CreateStoreOptions) =>
             set((state) => {
               state.transaction.sign.bipPath = bipPath;
             }),
-          updateHardWalletSigners: (signer: xdr.DecoratedSignature[]) =>
+          updateHardWalletSigs: (signer: xdr.DecoratedSignature[]) =>
             set((state) => {
-              state.transaction.sign.hardWalletSigners = signer;
+              state.transaction.sign.hardWalletSigs = signer;
             }),
           resetSign: () =>
             set((state) => {