1682 fix config/version tests #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifropc
force-pushed
the
1682-help-tests
branch
2 times, most recently
from
e4b3254 to
2b58f20
Compare
Ifropc
force-pushed
the
1682-config-tests
branch
from
12946e3 to
b856053
Compare
leighmcculloch
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of #1682 fixing config and version tests.
This PR addresses missing networks from
lsand fixes a bug leading to missing file error when stellar config directory didn't exist on saving configurationWhy
Test fixes
Known limitations
Some unrelated tests fail, see #1682