fix: parse XDR Result to JSON; encode RawVal return types #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test here copies the logic of [the errors example](https://github.com/stellar/soroban-examples/blob/main/errors/src/lib.rs), showing that valid `Ok` results were not being correctly parsed to JSON. Co-authored-by: Willem Wyndham <[email protected]>
paulbellamy
reviewed
Mar 30, 2023
paulbellamy
approved these changes
Mar 31, 2023
|
The reason that we we used both was for the UDT cases. That is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Two new tests show some errors that revealed themselves while adding CLI tests:
Okresults were not being correctly parsed to JSONRawValreturn types were causing errorsWhy
These tests expose real problems that have existed in soroban-cli's
mainbranch since updating to the latest XDR definitionsKnown limitations
N/A