rework some tests based on feedback

stellar · Oct 3, 2024 · e41f9a2 · e41f9a2
1 parent b13c166
commit e41f9a2
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 19 deletions.
diff --git a/models/staging/stg_account_signers.yml b/models/staging/stg_account_signers.yml
@@ -38,6 +38,9 @@ models:
       - name: ledger_entry_change
         tests:
           - not_null
+          - accepted_values:
+              values: [0, 1, 2]
+              quote: false
       - name: deleted
         description: '{{ doc("deleted") }}'
         tests:

diff --git a/models/staging/stg_claimable_balances.yml b/models/staging/stg_claimable_balances.yml
@@ -49,13 +49,9 @@ models:
 
       - name: asset_code
         description: '{{ doc("asset_code") }}'
-        tests:
-          - not_null
 
       - name: asset_issuer
         description: '{{ doc("asset_issuer") }}'
-        tests:
-          - not_null
 
       - name: asset_id
         description: '{{ doc("asset_id") }}'

diff --git a/models/staging/stg_contract_code.yml b/models/staging/stg_contract_code.yml
@@ -12,7 +12,6 @@ models:
       - dbt_utils.unique_combination_of_columns:
           combination_of_columns:
             - contract_code_hash
-            - contract_code_ext_v
             - last_modified_ledger
             - ledger_entry_change
           meta:

diff --git a/models/staging/stg_contract_data.yml b/models/staging/stg_contract_data.yml
@@ -11,8 +11,7 @@ models:
             description: "Monitors the freshness of your table over time, as the expected time between data updates."
       - dbt_utils.unique_combination_of_columns:
           combination_of_columns:
-            - contract_id
-            - contract_data_xdr
+            - ledger_key_hash
             - last_modified_ledger
             - ledger_entry_change
           meta:
@@ -35,13 +34,9 @@ models:
 
       - name: asset_code
         description: '{{ doc("asset_code") }}'
-        tests:
-          - not_null
 
       - name: asset_issuer
         description: '{{ doc("asset_issuer") }}'
-        tests:
-          - not_null
 
       - name: asset_type
         description: '{{ doc("asset_type") }}'

diff --git a/models/staging/stg_history_assets.yml b/models/staging/stg_history_assets.yml
@@ -31,13 +31,9 @@ models:
 
       - name: asset_code
         description: '{{ doc("asset_code") }}'
-        tests:
-          - not_null
 
       - name: asset_issuer
         description: '{{ doc("asset_issuer") }}'
-        tests:
-          - not_null
 
       - name: batch_id
         description: '{{ doc("batch_id") }}'

diff --git a/models/staging/stg_trust_lines.yml b/models/staging/stg_trust_lines.yml
@@ -38,13 +38,9 @@ models:
 
       - name: asset_issuer
         description: '{{ doc("asset_issuer") }}'
-        tests:
-          - not_null
 
       - name: asset_code
         description: '{{ doc("asset_code") }}'
-        tests:
-          - not_null
 
       - name: liquidity_pool_id
         description: '{{ doc("liquidity_pool_id") }}'