Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untag staging and intermediate models #114

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

sydneynotthecity
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to major/* , minor/* or patch/* .

What

Addresses https://stellarorg.atlassian.net/browse/HUBBLE-576

Untags staging and intermediate models so that the models aren't unnecessarily built based on tags.

Why

Airflow executes dbt models according to tags. Some upstream models were tagged unnecessarily and rebuilt every dbt run. (ie, enriched_history_operations) this was causing dbt tests to fail if there were data delays, causing noisy alerts.

This change pushes model dependency management back into dbt. Models should be rebuilt using dbt --select +tag:<tag>. This will ensure models are only built when the downstream mart model executes, reducing noise and test execution.

Known limitations

This PR must be released with corresponding Airflow changes to introduce + node selection to dbt model execution commands. If we are pushing dependency management into dbt, the command must rebuild dependent models.

@sydneynotthecity sydneynotthecity requested a review from a team as a code owner November 11, 2024 16:05
@sydneynotthecity sydneynotthecity merged commit b4ff3fe into master Nov 11, 2024
3 checks passed
@sydneynotthecity sydneynotthecity deleted the patch/untag-stage-int-models branch November 11, 2024 18:48
amishas157 added a commit that referenced this pull request Nov 13, 2024
amishas157 added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants