Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust recency tests, tag appropriately #125

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

sydneynotthecity
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to major/* , minor/* or patch/* .

What

Adjust recency tests for source data and _current state tables.

The following changes were applied:

  • add a tag to stg_* models, called "recency". This aligns with our target models
  • Increased the recency test range to 24 hours for _current tables in testnet env
  • increased the recency test range to 48 hours for claimable_balances in pubnet

Why

Over the break, many tests were noisy due to lack of activity in testnet and mainnet. The testnet intervals were adjusted so that we aren't alerted as frequently on less used features (claimable balances, liquidity pools)

The recency tests for the source tables also weren't tagged appropriately, meaning they were missed from our recency dag. Added in case we need summarized data for all table freshness.

Known limitations

[TODO or N/A]

@sydneynotthecity sydneynotthecity requested a review from a team as a code owner January 3, 2025 15:20
@sydneynotthecity sydneynotthecity merged commit 1b18e08 into master Jan 3, 2025
3 checks passed
@@ -4,6 +4,7 @@ models:
- name: stg_account_signers
tests:
- dbt_utils.recency:
tags: [recency]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this tag will trigger tests on staging models as part of recency DAG

However, recency DAG was designed to only trigger tests for final tables: marts

staging tests are triggered as part of model build. Do we want to trigger staging recency checks apart from model builds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants