Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update soroban pipelines #17

Merged
merged 12 commits into from
Feb 15, 2024
Merged

Update soroban pipelines #17

merged 12 commits into from
Feb 15, 2024

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Jan 29, 2024

Add Soroban pipelines and changes

  • Added source/stg tables for new soroban tables
  • Updated stg_history_operations, stg_history_effects, and stg_history_transactions with new soroban columns
  • Updated enriched history operations tables to include new soroban columns
  • Update docs
  • Add ttl_current table

Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had some questions for my own understanding of the data model

models/docs/sources/config_settings.md Show resolved Hide resolved
models/docs/sources/config_settings.md Show resolved Hide resolved
models/marts/enriched_history_operations.sql Show resolved Hide resolved
models/marts/ledger_current_state/ttl_current.sql Outdated Show resolved Hide resolved
description: '{{ doc("ttl_current") }}'
tests:
- dbt_utils.recency:
datepart: hour
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this truncate the timestamp to the hourly level? Like if data was older than 24+ hours, would we get an alert? or is this truly evaluating only the hour part of the datetime field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The truncate should be fine because datetime still has the hh:mm:ss part of the timestamp. I'm not sure about the 24+ hours alert. I would hope that dbt_utils is smart enough to take the datetime_diff instead of the extract(hour) - extract(hour)

We should probably test it but also we would get an error before this would be a problem because the _current table are run every 30 mins so we would hit the 12 hour recency test regardless

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. let's test and adjust appropriately

models/sources/src_contract_code.yml Outdated Show resolved Hide resolved
models/sources/src_history_effects.yml Outdated Show resolved Hide resolved
models/staging/stg_history_operations.sql Show resolved Hide resolved
@chowbao chowbao merged commit b7287db into master Feb 15, 2024
@sydneynotthecity sydneynotthecity deleted the add-soroban-pipelines branch November 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants