Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singular tests tag to set Airflow DAG #48

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

eduardo-nercolini
Copy link
Contributor

@eduardo-nercolini eduardo-nercolini commented Jun 11, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/* , feature/* or patch/* .

What

Added "singular_test" tag to the singular data tests in dbt so they can be used in the Airflow DAG configuration, allowing these tests to run at a defined frequency.

Why

As requested, the singular tests must run at a different frequency from the current model's build DAGs. For this purpose, a tag has been added so that the DAG and task could be designed using this tag

Known limitations

N/A

@@ -1,4 +1,8 @@
{{ config(severity="warn") }}
{{ config(
severity="warn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming: will the warn severity still alert in the slack channel? Otherwise we might have to increase the severity to get the alert in slack

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it continues to send alerts even though the severity is configured as warn. This was the case with an alert that was triggering every 30 minutes, and we had to set up a suppression interval to send it only once a day. Here's an example of such an alert for one of these tests: https://indicium-external.slack.com/archives/C06KR1UB6TG/p1716595711802759

@eduardo-nercolini eduardo-nercolini merged commit b76607c into master Jun 12, 2024
1 check passed
@sydneynotthecity sydneynotthecity deleted the feature/singular_tests_tag branch November 14, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants