Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUBBLE 465] Migrate dbt project evaluator and tests to Github Actions #59

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

eduardo-nercolini
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and the README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/_ , feature/_ or patch/* .

What

This PR add dbt project evaluator package to run on GitHub Actions.

Why

Misconfiguration are not caught until code is merged to the master branch since these steps only run during the jenkins pipeline. Migrating the dbt build actions to GitHub actions allows to enable ci/cd to the internal repo, and ensure bad code does not get merged to the master branch.

Known limitations

N/A

@eduardo-nercolini eduardo-nercolini requested a review from a team as a code owner July 4, 2024 14:22
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the disabled checks for dbt_project_evaluator due to the current problems with the dbt Jenkins build? Is the intent that these checks will always be disabled, or is this temporary until we get the build working again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answer: these will always be disabled unless we decide to increase the quality checks by the project evaluator.

@sydneynotthecity sydneynotthecity merged commit f6a920e into master Jul 12, 2024
3 checks passed
@sydneynotthecity sydneynotthecity deleted the feature/project_evaluator_ci branch November 14, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants