Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition of additional fields in history ledger table #62

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

amishas157
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/* , feature/* or patch/* .

What

When I created this earlier PR #57, I missed adding definition of additional fields in source file. This is why the definitions were not reflected on dbt docs.

After adding changes this PR, the docs look good
Screenshot 2024-07-16 at 2 48 16 PM

Why

Covered above

Known limitations

To check with Simon/Syd, if these tests make sense or not.

@amishas157 amishas157 requested a review from a team as a code owner July 16, 2024 19:49
@amishas157 amishas157 changed the title Add definition of existing fields in history ledger table Add definition of additional fields in history ledger table Jul 16, 2024
tests:
- not_null:
config:
where: closed_at > current_timestamp - interval 2 day
Copy link
Contributor Author

@amishas157 amishas157 Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if these test config apply to these 3 fields

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They apply to node_id and signature, but idk how soroban_fee_write_1kb is handled for old data. I think it would be aggressive for us to add a null check to that field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Gonna 🔪 it

Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

General note: if you want this PR to follow semvar for releases, you'll need to add patch/* to your branch name so that the release is tagged appropriately. Changes are good

@amishas157 amishas157 merged commit ff22d19 into master Jul 16, 2024
3 checks passed
@sydneynotthecity sydneynotthecity deleted the update-source-history-ledgers branch November 14, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants