Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use asset type enum string for trustline tables #64

Merged
merged 7 commits into from
Jul 22, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Jul 17, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/* , feature/* or patch/* .

What

This PR updates the values of AssetType for Trustlines tables from integer to string. Related PR in upstream pipeline stellar/stellar-etl#268

Why

This is done to make AssetType consistent across all the schemas as it was mistakenly added as integer earlier.

Known limitations

None

@amishas157 amishas157 marked this pull request as ready for review July 22, 2024 15:45
@amishas157 amishas157 requested a review from a team as a code owner July 22, 2024 15:45
lint again
@amishas157 amishas157 force-pushed the feature/update-asset-type-data-type branch from 3692d3e to a9c243d Compare July 22, 2024 15:55
@amishas157 amishas157 merged commit f3bf424 into master Jul 22, 2024
3 checks passed
@sydneynotthecity sydneynotthecity deleted the feature/update-asset-type-data-type branch November 14, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants