New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to use closed_at instead of batch_run_date #73

Draft

chowbao wants to merge 1 commit into master from patch/updates-to-use-closed-at-instead-of-batch-run-date

Contributor

chowbao commented Aug 5, 2024 •

edited

Loading

PR Checklist

PR Structure

This PR has reasonably narrow scope (if not, break it down into smaller PRs).
This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
This PR's title starts with the jira ticket associated with the PR.

Thoroughness

This PR adds tests for the most critical parts of the new functionality or fixes.
I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

I've decided if this PR requires a new major/minor/patch version accordingly to
semver, and I've changed the name of the BRANCH to release/* , feature/* or patch/* .

What

Changing dbt models to use closed_at instead of batch_run_date

Why

Part of https://stellarorg.atlassian.net/browse/HUBBLE-342
Make all tables partitioned on closed_at for a better and more consistent user experience

Known limitations

Need to test on testnet and pubnet data
Need to find metabase queries that will be impacted and update them as well
Currently fails ci/cd


          Updates to use closed_at instead of batch_run_date

4e02dd5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet