Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timestamp sub for greater than condition #84

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

amishas157
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/* , feature/* or patch/* .

What

[TODO: Short statement about what is changing.]

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@amishas157 amishas157 force-pushed the patch/fix-recency-bug branch from b7dd754 to 951a949 Compare September 5, 2024 00:53
@amishas157 amishas157 changed the title Use timestamp sub for less than condition Use timestamp sub for greater than condition Sep 5, 2024
@amishas157 amishas157 marked this pull request as ready for review September 5, 2024 00:58
@amishas157 amishas157 requested a review from a team as a code owner September 5, 2024 00:58
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sydneynotthecity sydneynotthecity merged commit e2460c7 into master Sep 5, 2024
3 checks passed
@sydneynotthecity sydneynotthecity deleted the patch/fix-recency-bug branch November 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants