Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typography docs + preview #166

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Typography docs + preview #166

merged 4 commits into from
Sep 11, 2023

Conversation

quietbits
Copy link
Contributor

@quietbits quietbits commented Sep 7, 2023 •
edited
Loading

image

@stellar-jenkins
Copy link

Preview is available here:
http://design-system-pr166.previews.kube001.services.stellar-ops.com/

quietbits
quietbits commented Sep 7, 2023
View reviewed changes
@stellar/design-system/src/components/Typography/index.tsx
interface HProps
extends HeadingProps,
React.HtmlHTMLAttributes<HTMLHeadingElement> {
children: string | React.ReactNode;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the children type here (and other typography components below) because the global children type from the extended interface is not compatible with what we want.

@quietbits quietbits merged commit 938fe75 into v2-website Sep 11, 2023
1 check passed
@quietbits quietbits deleted the preview-typography branch September 11, 2023 13:41
quietbits added a commit that referenced this pull request Oct 23, 2023
@quietbits @aristidesstaffieri @briwylde08
New SDS website built with Docusaurus (#158)
cd4304f 
* Updated gitignore

* Website Docusaurus config (#157)

* Node v18 + update eslint

* Update prettier + tsconfig

* Minor dep updates

* Some major dep updates

* More major dep updates

* Fix eslint import errors in SDS web

* Upgrade React 17 to 18

* Update GH action to use Node v18

* Updated colors

* SDS v2: typography (#125)

* Updated typography + pxToRem function

* Fix asset path when refreshing sub-pages

* Remove Link + Code from Typography + add descriptions

* Temp file to trigger PR preview

* Replace IBM Plex Sans font (#126)

* Replace icons + optimize logos (#127)

* ThemeSwitch component (#128)

* Replace icons + optimize logos

* New theme switch + SVG cleanup

* Cleanup

* Updated Button component (#131)

* Updated Button component

* Update colors, border radius, padding

* Updated Input component (#132)

* Input update in progress

* Updated Input component

* Updated Link component (#133)

* Updated Icon component

* Use left arrow on the left side

* Update Notification component (#134)

* Update Notification component

* Update icon size

* SDS version 1.0.0-beta.0

* Update logos SVGs + cleanup

* SDS version 1.0.0-beta.1

* Updated Card, Input, and Button components + small tweaks (#135)

* Card component + small tweaks

* Button: add isPill prop

* Input: add isPill prop

* Button: add isExtraPadding prop

* Badge component (#137)

* Updated Checkbox and RadioButton components (#136)

* Updated Checkbox

* Update RadioButton

* Checkbox fieldSize prop

* RadioButton fieldSize prop

* Updated Select component (#138)

* Updated Textarea component (#139)

* Updated Textarea component

* Cleanup

* Minor global CSS updates

* SDS version 1.0.0-beta.2

* Banner component (#140)

* Rename StatusBar to Banner

* Fix typo

* Banner component

* Various small tweaks (#141)

* Checkbox without label

* Make Button label optional

* Add error without message prop to form components

* SDS version 1.0.0-beta.3

* Updated Tooltip + some tweaks (#142)

* Updated Badge

* Floater component + updated Tooltip and CopyText

* Updated Avatar + small tweaks (#143)

* Extra padding for form inputs

* Avatar + AssetIcon components

* Profile component

* Profile copy address

* SDS version 1.0.0-beta.4

* Floater fix + SDS version 1.0.0-beta.5

* Another floater fix + SDS version 1.0.0-beta.6

* Serve stellar-identicon-js locally (#144)

* Floater and tooltip color update and small fix (#145)

* SDS version 1.0.0-beta.7

* Optional title for ProjectLogo and Layout.Header (#147)

* allows for optional title in ProjectLogo and Layout.Header

* turns boolean expression to ternary for optional title and updates props on website details

* SDS version 1.0.0-beta.8

* SDS version 1.0.0-beta.9

* rename classNames prop to addlClassName (#148)

* rename classNames prop to addlClasses

* renames addlClasses to addlClassName

* bumps version tag for sds

* picks out addlClassName from props before spreading onto dom nodes (#149)

* picks out addlClassName from props before spreading onto dom nodes

* updates website props for typography components

* SDS version 1.0.0-beta.11

* Button: update tertiary colors (#150)

* Toggle updated + small tweaks (#151)

* Button: destructive/error/success variants (#152)

* Button: destructive/error/success variants

* Update Button gap

* Updated Card component

* Updated Modal component (#153)

* SDS version 1.0.0-beta.12

* Add new icons (#154)

* SDS version 1.0.0-beta.13

* Input password preset (#155)

* Remove icon added (#156)

* SDS version 1.0.0-beta.14

* Basic Docusaurus setup

* Basic SDS example

* Make docs initial page

* Fix broken link

* Temp rename

* Enable Docusaurus website

---------

Co-authored-by: aristides <[email protected]>
Co-authored-by: Aristides Staffieri <[email protected]>

* Quick example creating docs with TypeDoc (#159)

* Quick example creating docs with TypeDoc

* Attempt to fix broken build

* Fix gitignore

* Style main layout (#160)

* Style main layout

* Fix logo font

* Main categories with placeholder pages + styled typography (#161)

* Main categories + page placeholders

* Update typography styles

* Component doc template (#162)

* Component doc template

* Fix build

* Component preview (#163)

* Preview component example with Button

* Remove link page for now

* Add Link page

* Fix SSR

* Icon dropdown

* Updated controls UI

* Update controls UI

* Component preview: Link (#164)

* Social card image + small preview tweaks

* ProjectLogo preview (#165)

* Typography docs + preview (#166)

* Heading docs + preview

* Caption docs + preview

* Paragraph docs + preview

* Title docs + preview

* Notification docs + preview (#167)

* Notification docs + preview

* Cleanup

* Update Stellar logo (#168)

* Banner docs + preview (#169)

* Avatar docs + preview (#171)

* Badge docs + preview (#170)

* Profile docs + preview (#172)

* Loader docs + preview (#173)

* AssetIcon docs + preview (#174)

* AssetIcon docs + preview

* Cleanup

* Tooltip docs + preview (#175)

* Tooltip docs + preview

* Trigger PR preview

* Input docs + preview (#176)

* Input docs + preview

* Disabled preview

* Select docs + preview (#177)

* Select docs + preview

* Disabled preview

* Textarea docs + preview (#178)

* Textarea docs + preview

* Fix styles

* Checkbox docs + preview (#179)

* RadioButton docs + preview (#180)

* Toggle docs + preview (#181)

* IconButton and ButtonPreset docs + preview (#182)

* IconButton docs + preview

* ButtonPreset docs + preview

* NavButton docs + preview (#183)

* CopyText docs + preview (#184)

* Pagination docs + preview (#186)

* Card docs + preview (#185)

* Modal docs + preview (#187)

* Layout docs + preview (#188)

* Table docs + preview (#189)

* Icon and Logo docs + preview (#190)

* Icon and Logo docs + preview

* Fix server side rendering

* Updated intro + readme (#191)

* Updated intro + readme

* Updated text

* Editorial (#192)

* intro editorial

* components - buttons

* components - accents

* components - branding

* components - containers

* components - elements

* components - inputs

* components - layout

* components - notifications

* components - profile

* foundations - typography

* SDS website: add component short descriptions (#193)

* Website: small UI tweaks (#194)

* SDS v1.0.0

---------

Co-authored-by: aristides <[email protected]>
Co-authored-by: Aristides Staffieri <[email protected]>
Co-authored-by: Bri Wylde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyalbasu piyalbasu piyalbasu approved these changes

@aristidesstaffieri aristidesstaffieri Awaiting requested review from aristidesstaffieri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quietbits @stellar-jenkins @piyalbasu