Label info link + update Tooltip theme setting #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is available here: |
|
Preview is available here: |
quietbits
commented
Apr 30, 2024
Comment on lines
+56
to
+64
| callback={(isOpen) => { | ||
| if (isOpen) { | ||
| const theme = document.body.getAttribute("data-sds-theme"); | ||
|
|
||
| if (theme) { | ||
| setTheme(theme); | ||
| } | ||
| } | ||
| }} |
There was a problem hiding this comment.
Using a callback is more accurate than using a listener.
quietbits
commented
Apr 30, 2024
| @@ -60,22 +60,14 @@ export const ThemeSwitch = ({ | |||
| if (isDarkMode) { | |||
| document.body.classList.remove(ThemeMode.LIGHT); | |||
| document.body.classList.add(ThemeMode.DARK); | |||
| document.body.setAttribute("data-sds-theme", ThemeMode.DARK); | |||
There was a problem hiding this comment.
Other components can check for this attribute to get the current theme.
jeesunikim
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info text (in tooltip)
Info link (opens in new window)
