Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option type #1232

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add Option type #1232

wants to merge 7 commits into from

Conversation

carstenjacobsen
Copy link
Contributor

Two commits for #485

Please check if the description makes sense, and if the description is in the right place. It seems like the Built-In-Types is the best fit, but it might not be.

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, other lgtm.

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

1 similar comment
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

@carstenjacobsen
Copy link
Contributor Author

Reopening the PR

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

1 similar comment
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

The tip formatting was not correct, it needed a blank line above and under the tip markdown.
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

1 similar comment
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@briwylde08
Copy link
Contributor

This PR is so unhappy

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants