Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elementary profile in profiles.yml #249

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

lucaszanotelli
Copy link
Contributor

This PR adds a profile to the profiles.yml so the elementary hook can access to BigQuery.

This follows the docs: https://docs.elementary-data.com/deployment-and-configuration/elementary-in-production

@lucaszanotelli lucaszanotelli requested a review from a team as a code owner November 20, 2023 17:12
@lucaszanotelli lucaszanotelli force-pushed the add-elementary-profile-name branch from 78a85f6 to fa020e1 Compare November 20, 2023 21:22
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Was elementary already running during our production workflow, but we weren't writing the results anywhere?

@lucaszanotelli
Copy link
Contributor Author

lucaszanotelli commented Nov 21, 2023

LGTM

Was elementary already running during our production workflow, but we weren't writing the results anywhere?

On the dbt side, elementary was good to go; but on the Airflow side, it was missing a profile named elementary inside the profiles.yml.

Only this addition was suppose make it work but I'm still not seeing the elementary dataset being created/populated.

I'm currently working on fixing this.

@lucaszanotelli
Copy link
Contributor Author

up and running!

@lucaszanotelli lucaszanotelli merged commit ecfa767 into master Nov 21, 2023
4 checks passed
lucaszanotelli added a commit that referenced this pull request Nov 21, 2023
* add `elementary` profile in `profiles.yml`

* remove `target`

* remove useless whitespace

* add `elementary` model to `select` flag

Co-authored-by: lucas zanotelli <[email protected]>
@lucaszanotelli lucaszanotelli deleted the add-elementary-profile-name branch November 24, 2023 14:46
sydneynotthecity pushed a commit that referenced this pull request Mar 5, 2024
* add `elementary` profile in `profiles.yml`

* remove `target`

* remove useless whitespace

* add `elementary` model to `select` flag

Co-authored-by: lucas zanotelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants