-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate cdp changes to ingest from datastore txmeta files #333
Conversation
Oops this was supposed to be draft PR 🤷♀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts on how we're going to deploy cdp and replace the old DAGs? Curious how you're thinking about that.
dags/cdp_history_archive_with_captive_core_combined_export_dag.py
Outdated
Show resolved
Hide resolved
dags/cdp_history_archive_with_captive_core_combined_export_dag.py
Outdated
Show resolved
Hide resolved
…etl-airflow into cdp-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nothing blocking the merge
catchup=True, | ||
description="This DAG exports trades and operations from the history archive using CaptiveCore. This supports parsing sponsorship and AMMs.", | ||
schedule_interval="*/30 * * * *", | ||
schedule_interval="*/10 * * * *", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any data/benchmarking yet on how well this DAG does on a 10 min interval?
In prod, we'll need to release in a couple steps to make sure we don't mess up the schedule interval shift:
- update old DAGs to include end date
- delete old DAGs
- add new DAG with new start date (that won't miss any gaps)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In test it takes about ~10 minutes to run (mostly cause of the slow startup time issue). So we won't ever fall behind the 10 min schedule
Integrate cdp changes to ingest from datastore txmeta files