Bump image versions #339
Merged
Bump image versions #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chowbao
reviewed
Apr 18, 2024
| @@ -198,8 +198,7 @@ def build_export_task( | |||
| else: | |||
| arguments = f""" | |||
| {etl_cmd_string} 2>> stderr.out && echo "{{\\"output\\": \\"{output_file}\\", | |||
| \\"failed_transforms\\": `grep failed_transforms stderr.out | cut -d\\",\\" -f2 | cut -d\\":\\" -f2`\\", | |||
| \\"succcessful_transforms\\": `grep successful_transforms stderr.out | cut -d\\",\\" -f2 | cut -d\\":\\" -f2`}}" >> /airflow/xcom/return.json | |||
| \\"failed_transforms\\": `grep failed_transforms stderr.out | cut -d\\",\\" -f2 | cut -d\\":\\" -f2`}}" >> /airflow/xcom/return.json | |||
There was a problem hiding this comment.
Why remove succcessful_transforms?
There was a problem hiding this comment.
Because this code is broken and raises the error:
json.decoder.JSONDecodeError: Expecting ',' delimiter: line 2 column 43 (char 133)
Laysa is working on a fix in #338
chowbao
reviewed
Apr 18, 2024
| LOCATION: us-central1 | ||
| with: | ||
| args: > | ||
| components install kubectl && gcloud composer environments run | ||
| $COMPOSER_ENVIRONMENT --location $LOCATION variables import | ||
| -- gcsfuse/variables.json | ||
| -- gcsfuse/actual_mount_path/variables.json |
There was a problem hiding this comment.
It's another lovely quirk of composer 2. gcsfuse used to be mounted to the actual bucket where DAGs are stored....but now is mounted to gcsfuse/actual_mount_path.
Why? Great question
chowbao
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
stellar-etlandstellar-dbtto the latest images.Repoint the ci to composer 2 testnet environment.
TODO: will repoint mainnet env to composer 2 once validation completes.Added new Airflow dbt tags for SCD snapshot tables