Improve deploy process using custom github action #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test 1:
The middle column in following shows branch name I changed image_name from ✅ Verify the results in airflow variables |
|
Results of if else condition:
✅ Deploys to dev from feature branch
✅ Skips deploys to prod from feature branch
✅ Deploys to dev from master branch
✅ Deploys to prod from master branch |
amishas157
force-pushed
the
test-deploy-workflow
branch
from
50e12a0 to
72a94df
Compare
amishas157
commented
Jul 26, 2024
| - name: Display Environment Name | ||
| run: echo "Hello ${{ inputs.envName }}" | ||
|
|
||
| pre-commit: |
There was a problem hiding this comment.
This is not needed anymore. We would require it only for merging
amishas157
changed the title
chowbao
reviewed
Jul 26, 2024
Co-authored-by: chowbao <[email protected]>
chowbao
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
Thoroughness
What
This PR updates deploy github workflow such that,
This PR also deletes the prod.yml workflow file as it is not needed anymore.
Why
The existing workflow to use two branches - release and master and then auto-creating a PR to release is not smooth. There occurs merge conflicts often.
Known limitations
None. See testing results in comments below