Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back dbt 1.8 #476

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Bring back dbt 1.8 #476

merged 2 commits into from
Aug 15, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Aug 15, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository.

What

Ref: #475

This PR fixes error shown up from dbt upgrade.

Why

Noted inline

Known limitations

[TODO or N/A]

@@ -107,7 +107,7 @@
"endpoint": "https://api.coingecko.com/api/v3/coins/tether-eurt/ohlc?vs_currency=usd&days=1",
"table_name": "euro_usd_ohlc"
},
"dbt_dataset_for_test": "",
"dbt_dataset_for_test": "placeholder_value",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is used in following

dbt_dataset = "{{ var.value.dbt_dataset_for_test }}"

In previous versions of dbt <=1.3, it was okay to pass empty string in dbt_dataset but not anymore. Also this value does not mean anything. It is just a required variable

@amishas157 amishas157 marked this pull request as ready for review August 15, 2024 22:59
@amishas157 amishas157 requested a review from a team as a code owner August 15, 2024 22:59
@amishas157 amishas157 merged commit e51e0fe into master Aug 15, 2024
2 checks passed
@sydneynotthecity sydneynotthecity deleted the bring-back-dbt-1.8 branch November 21, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants