Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DBT image (ephemeral model to materialized tables) #478

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Aug 16, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository.

What

This PR updates DBT image. Context below from DBT PR

While auditing the tests for DBT, it was found out that tests for intermediate models int_trade_agg* will take ~300 seconds in prod. This was because it will create ephemeral model for each test and then run the test.
This PR updates the intermediate tables to be materialized rather than being ephemeral.

Why

Improve test run time in int_trade_agg* models.

Known limitations

None

@amishas157 amishas157 marked this pull request as ready for review August 16, 2024 19:52
@amishas157 amishas157 requested a review from a team as a code owner August 16, 2024 19:52
@amishas157 amishas157 changed the title Switch image Update DBT image (ephemeral model to materialized tables) Aug 16, 2024
@amishas157 amishas157 merged commit 0e4f7b6 into master Aug 16, 2024
5 checks passed
@sydneynotthecity sydneynotthecity deleted the patch/ephemeral-to-table branch November 21, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants