Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run singular tests conditionally #498

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Run singular tests conditionally #498

merged 4 commits into from
Sep 19, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Sep 18, 2024 •
edited
Loading

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository.

What

Corresponding to stellar/stellar-dbt-public#95

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@amishas157 amishas157 changed the title Pass is_singular_airflow_task env var Run singular tests conditionally Sep 18, 2024
@amishas157 amishas157 marked this pull request as ready for review September 18, 2024 18:46
@amishas157 amishas157 requested a review from a team as a code owner September 18, 2024 18:46
chowbao
chowbao approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@chowbao chowbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; We can handle updating the --exclude tags like in the eho task/dag and cadence of singular tests (currently every 30 mins) in a separate PR

@amishas157 amishas157 merged commit 8ee08f2 into master Sep 19, 2024
2 checks passed
@sydneynotthecity sydneynotthecity deleted the patch/run-singular-test-conditionally branch November 21, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneynotthecity sydneynotthecity sydneynotthecity approved these changes

@chowbao chowbao chowbao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amishas157 @chowbao @sydneynotthecity