Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to calculate schema changes #517
Add workflow to calculate schema changes #517
Changes from 17 commits
dbe09b2
9359a4c
770f21b
8db5b45
b6e2855
54aa097
3055b2b
d59b89f
8b98baa
48e8c77
e481aed
0d1bb39
2059018
711a51f
cd51fa2
3e5d889
6812581
8b420dc
58743a4
f3f5b18
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm is it possible to make this append instead of overwrite the entire changelog each run?
There might be a time we delete the
elementary.alerts_schema_changes
table like the times we have deleted the wholeelementary
dataset because it was broken or elementary was doing something unexpected.If it's too hard to make this append instead of overwrite we should remember to keep a copy of
elementary.alerts_schema_changes
otherwise we'd lose changelog historyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrm this process is pretty dependent on
elementary.alerts_schema_changes
. Even if we were to delete this dataset ever, that in itself will affect changelog computing part. So ideally we should not delete that dataset.However as far as append is concerned, we could
Structure of .md file:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But also, I think it's quite a bit of text formatting. We can leave it as is and can revisit later if needed. In the first place, I don't think we are going to see a lot of schema changes in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup sounds good