Update sandbox dag with retool #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dags/sandbox_update_dag.py
Outdated
Comment on lines
74
to
77
| if table_id == "retool_entity_data": | ||
| sql_params["project_id"] = SANDBOX_PROJECT | ||
| sql_params["dataset_id"] = INTERNAL_DATASET | ||
|
|
There was a problem hiding this comment.
Do we need to copy this table over to the sandbox? I believe canvas has full access to crypto_stellar_internal_2 tables, but we may need to confirm. Since the table is only 30 rows, there is no reason for us to rebuild
There was a problem hiding this comment.
Oh I didn't know that. If they have access then I can change this to just exclude retool_entity_data instead
There was a problem hiding this comment.
Update: canvas does not have access to the dataset. My preference would be to build a view in the sandbox instead of a table
There was a problem hiding this comment.
Updated to skip retool_entity_data
312cd07
There was a problem hiding this comment.
View created in sandbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sandbox_update_dag to pull retool data from the correct project.dataset