Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-41: add mint and clawback event #1588

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

SEP-41: add mint and clawback event #1588

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
05cc3b5
add mint event to sep-41
chowbao Dec 12, 2024
095dc41
Update sep-0041.md
chowbao Jan 8, 2025
6b1057f
Update sep-0041.md
chowbao Jan 8, 2025
a14bae4
Merge branch 'master' into sep-41-add-mint-event
chowbao Jan 8, 2025
5f29fdf
Update sep-0041.md
chowbao Jan 15, 2025
b8aa496
Update sep-0041.md
chowbao Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions ecosystem/sep-0041.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
```
SEP: 0041
Title: Soroban Token Interface
Authors: Jonathan Jove <@jonjove>, Siddharth Suresh <@sisuresh>
Authors: Jonathan Jove <@jonjove>, Siddharth Suresh <@sisuresh>, Simon Chow <@chowbao>
Track: Standard
Status: Draft
Status: Final
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this update should change the status. Changing the status is unnecessary and hasn't been discussed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to leave it in Draft still? That seems weird if custom tokens are actively using the SEP (and will use the updated SEP with mint/clawback)

How do we decide if a SEP should be active/final?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets have that discussion, but not bundle a status change with a functional change. The fact we're making a functional change is an indicator it still belongs in Draft, because Draft is the state that functional changes occur in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some discussion about SEP statuses in https://github.com/stellar/stellar-protocol/blob/master/ecosystem/README.md#draft-merging--further-iteration

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that's fair it should have already been updated from Draft to Active/Final before these functional changes. But it's just lucky happenstance that it is still in Draft and we can keep it in draft for these changes

Updated in b8aa496

Copy link
Member

@leighmcculloch leighmcculloch Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's debatable. While the SAC implements SEP-41 there are not a significant number of custom tokens, and given the ecosystem around events is still developing (unified events work as evidence) SEP-41 still has some room to prove itself before we flag it as Final.

Created: 2023-09-22
Updated: 2023-10-18
Updated: 2025-01-08
Version 0.2.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version should be bumped

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Updated in 5f29fdf

Discussion: https://discord.com/channels/897514728459468821/1159937045322547250
Discussion: https://discord.com/channels/897514728459468821/1159937045322547250, https://github.com/stellar/stellar-protocol/discussions/1584
```

## Simple Summary
Expand Down Expand Up @@ -208,10 +208,37 @@ The event has data:

- `i128` the amount burned.

#### Mint Event

The `mint` event is emitted when an amount of the token is minted.

The event has topics:

- `Symbol` with value `"mint"`
- `Address` the address to hold the newly minted tokens.

The event has data:

- `i128` the amount minted.

#### Clawback Event

The `clawback` event is emitted when an amount of the token is clawed back.

The event has topics:

- `Symbol` with value `"clawback"`
- `Address` The address holding the balance from which the clawback will take tokens.

The event has data:

- `i128` the amount clawed back.

## Changelog

- `v0.1.0` - Initial draft based on [CAP-46-6].
- `v0.2.0` - Remove `spendable_balance`.
- `v0.3.0` - Add `mint` and `clawback` event
leighmcculloch marked this conversation as resolved.
Show resolved Hide resolved

## Implementations

Expand Down
Loading