Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Scenario added for Soroban Diagnostic Events #53

Merged
merged 6 commits into from
Apr 18, 2023

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Apr 14, 2023

Added new verification steps to the DApp developer compiles, deploys and invokes a contract scenario for asserting on soroban diagnostic events retreival from cli and node js.

Best place to start for a review is to check that scenario out in dapp_develop.feature to see the new diagnostic events verification parameters.

current test summary output:

9 scenarios (9 passed)
65 steps (65 passed)
5m9.152619264s
--- PASS: TestDappDevelop (309.15s)
    --- PASS: TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract (54.54s)
    --- PASS: TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract#01 (30.58s)
    --- PASS: TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract#02 (30.45s)
    --- PASS: TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract#03 (30.49s)
    --- PASS: TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract (31.45s)
    --- PASS: TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract#01 (30.64s)
    --- PASS: TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract#02 (31.64s)
    --- PASS: TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract#03 (31.84s)
    --- PASS: TestDappDevelop/DApp_developer_uses_config_states,_compiles,_deploys_and_invokes_contract_with_authorizations (37.53s)
PASS

Closes #40

To run the pr locally:

$ git fetch origin pull/53/head:pr_53 && git checkout pr_53
$ make  \
  CORE_GIT_REF=https://github.com/stellar/stellar-core.git#064a2787acb9e98c70567523785333581ee1ffa4 \
  CORE_COMPILE_CONFIGURE_FLAGS="--disable-tests --enable-next-protocol-version-unsafe-for-production" \
  SOROBAN_RPC_GIT_REF=https://github.com/stellar/soroban-tools.git#main \
  SOROBAN_CLI_GIT_REF=https://github.com/stellar/soroban-tools.git#main \
  build

$ docker run -it --name e2e_test stellar/system-test:dev --SorobanExamplesGitHash v0.7.0

@sreuland sreuland requested a review from a team April 14, 2023 16:08
@@ -0,0 +1,27 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the README mentions this file for example reference of how to run the test in a debugger during developent, for anyone developing on a test may find this a useful reference, not necessarily using it directly in vscode IDE.

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great.

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a js-soroban-client usage perspective! 👏

@sreuland sreuland merged commit 362a150 into stellar:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new system test for diagnostic events
3 participants