Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for new puppeteer version #1506

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

s-gurevich
Copy link
Contributor

  1. Adapted the documentation referencing to Stencil config file, because a property was changed in the recent updates
  2. Added new version of puppeteer to the support site

Background:
Chrome changed how they handle headless browser distribution: https://developer.chrome.com/blog/chrome-headless-shell
Puppeteer adapted their config: https://pptr.dev/guides/headless-modes
Stencil upgraded the puppeteer dependency and adapted their config.

headlessBrowser: 'new' is no longer accepted.

@s-gurevich s-gurevich requested a review from a team as a code owner February 7, 2025 13:38
@s-gurevich s-gurevich requested review from christian-bromann and matthewkremer and removed request for a team February 7, 2025 13:38
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 1:43pm

@s-gurevich s-gurevich changed the title Update docs for new puppeteer version docs: update docs for new puppeteer version Feb 7, 2025
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much 👍

@christian-bromann christian-bromann merged commit fa206ac into stenciljs:main Feb 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants