Update main from dev #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an entry to point to the Solarman sensor for "id_grid_import_today". Note, same change made to Solarman default in another commit.
1) Align the definition of "online" for Solarman to that within Solax/Core Modbus 2) Solarman, read maximum_dod_percent from the inverter rather than a fixed number from config.yaml
Add debug logging to verify all info before final write.
The Solarman integration appears to be no longer maintained. Update README to replace with https://github.com/davidrapan/ha-solarman
Add "SOLIS_SOLARMAN_V2" to INVERTER_DEFS to support Solarman from https://github.com/davidrapan/ha-solarman Reason: The entity names from this repo diffefr different from the previous Solarman repo at https://github.com/StephanJoubert/home_assistant_solarman
Add SOLIS_SOLARMAN_V2 defaults to config.yaml. Also tidy up config.yaml by moving solar entities under each integration and adding comment text on how to select each integration.
id_solar_power is only used for compare tariffs, so its not a default within Pv_opt. However, its different for each integration so replicate within each integration and add comment text to explain.
The Solarman_V2 integration (see config.yaml for github location) provides a single entity for start and end times rather than hours and minutes seperately. Update config.yaml and solis.py for SOLARMAN_V2 to take account of this.
Change "sensor" to "time" and "number" to match entitiy types provided by integration described by Solarman_V2
Change "sensor" to "time" and "number" to match entity types provided by integration described by Solarman_V2
Add debug logging Fix setting of "status[direction][limit]"
1) Reinstantiate seperate hours and minutes entities 2) Add commenting
1) Add "codes" to Solarman_V2 inverter_defs. 2) Modify Solarman_v2 to use codes for storage control selection (as it is a string entity, similar to Solax, rather than a number or enum) 3) Add a "changed" check to the code to allow suppression of the check at the point of write.
Updates for control of storage_control_register - "codes" removed from inverter_defs (added a few commits ago) as not needed.
config.yaml: Reinstantiate charge start/end ids in hours and minutes solis.py: fix typos introduced on last edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.