1st-CLaaS Kernel in WARP-V Configurator #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for warp-v ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevehoover
requested changes
Sep 9, 2024
| formattingSettings = settings.formattingSettings.filter(formattingArg => formattingArg !== "--fmtNoSource") | ||
| } | ||
| let boilerplate_1st_ClaaS = `\\m5_TLV_version 1d${formattingSettings.length > 0 ? ` ${formattingSettings.join(" ")}` : ""}: tl-x.org | ||
| \\m5 |
There was a problem hiding this comment.
We want as much of this file as possible to be placed in a library file and included. Anything the user might want to configure should remain here.
There was a problem hiding this comment.
You mean the functions like kernel module def and random tb should be part of a library file? lines 180-221.
And what about the kernel 1,2,3 pipelines from lines 276 to 378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A radio button in the configurator allows the option to generate 1st-CLaaS WARP-V kernel from the configurator