add settings option to reset legacy tag converter state

OneMore/Commands/Settings/HashtagSheet.cs

@@ -36,6 +36,7 @@ public HashtagSheet(SettingsProvider provider) : base(provider)
 					"scheduleLink",
 					"warningBox",
 					"upgradeLink",
+					"resetLink=word_Reset",
 					"disabledBox"
 				});
 			}
@@ -94,7 +95,9 @@ protected override async void OnLoad(EventArgs e)
 			base.OnLoad(e);
 
 			var converter = new LegacyTaggingConverter();
-			upgradeLink.Enabled = await converter.NeedsConversion();
+			var needsConversion = await converter.NeedsConversion();
+			upgradeLink.Enabled = needsConversion;
+			resetLink.Visible = !needsConversion;
 		}
 
 
@@ -116,10 +119,24 @@ private async void UpgradeTags(object sender, LinkLabelLinkClickedEventArgs e)
 			if (upgraded)
 			{
 				upgradeLink.Enabled = false;
+				resetLink.Visible = true;
 			}
 		}
 
 
+		private void ResetUpgradeCheck(object sender, LinkLabelLinkClickedEventArgs e)
+		{
+			// this will save settings.xml
+			LegacyTaggingConverter.ResetUpgradeCheck();
+
+			// now update local in-memory copy of settings
+			provider.RemoveCollection("tagging");
+
+			upgradeLink.Enabled = true;
+			resetLink.Visible = false;
+		}
+
+
 		public override bool CollectSettings()
 		{
 			// general...

OneMore/Commands/Settings/HashtagSheet.resx

@@ -117,4 +117,7 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <metadata name="tooltip.TrayLocation" type="System.Drawing.Point, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
+    <value>17, 17</value>
+  </metadata>
 </root>

OneMore/Commands/Tagging/LegacyTaggingConverter.cs

@@ -53,15 +53,19 @@ internal class LegacyTaggingConverter : Loggable
 		/// <returns>True if tags are or have been upgraded, otherwise false.</returns>
 		public async Task<bool> UpgradeLegacyTags(IWin32Window owner)
 		{
-			if (!await NeedsConversion())
+			var provider = new SettingsProvider();
+			var settings = provider.GetCollection("tagging");
+
+			if (!await NeedsConversion(settings))
 			{
+				settings.Add("converted", true);
+				provider.SetCollection(settings);
+				provider.Save();
+
 				Converted = true;
 				return false;
 			}
 
-			var provider = new SettingsProvider();
-			var settings = provider.GetCollection("tagging");
-
 			using var ltdialog = new LegacyTaggingDialog();
 
 			if (ltdialog.ShowDialog(owner) == DialogResult.OK)
@@ -103,8 +107,12 @@ public async Task<bool> UpgradeLegacyTags(IWin32Window owner)
 
 		public async Task<bool> NeedsConversion()
 		{
-			var provider = new SettingsProvider();
-			var settings = provider.GetCollection("tagging");
+			return await NeedsConversion(new SettingsProvider().GetCollection("tagging"));
+		}
+
+
+		private async Task<bool> NeedsConversion(SettingsCollection settings)
+		{
 			if (settings.Get("converted", false))
 			{
 				return false;
@@ -249,5 +257,13 @@ private async Task<bool> UpgradeLegacyTags(ProgressDialog dialog, CancellationTo
 
 			return !token.IsCancellationRequested;
 		}
+
+
+		public static void ResetUpgradeCheck()
+		{
+			var provider = new SettingsProvider();
+			provider.RemoveCollection("tagging");
+			provider.Save();
+		}
 	}
 }