-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/colour provider #564
base: master
Are you sure you want to change the base?
Feature/colour provider #564
Conversation
4169749
to
1579041
Compare
…es the colour wheel
… breaking compatibility
ColorWheel interface.
07b7ff8
to
7f9fa2c
Compare
…ld-Plotter-interface Keep Plotter::ResetColourWheel() for API compatiblilty
@stevenlovegrove I wonder if you could have a look at this PR. It's a relatively small feature. |
Hi Erick - sorry I've never replied on this PR. I really like the idea and have actually been meaning to modify it slightly. My main objection to the current implementation is that it breaks the API. I have also been wanting to support colormaps and have been wondering if there is a unified API that could be used for the discrete and continuous use cases. |
Adds an abstraction for color providers used by the plotter. ColourWheel becomes a provider, and it also adds a simple ColourCircularBuffer provider. The plotter constructor is overloaded to provide backwards compatibility, with the default being a ColourWheel provider (as before).
Same as before with the ColourWheel:
Using the simple ColourCircularBuffer (and shades of green):
The SimplePlot example is updated to showcase how this functionality works: