Update to modern Dart style and lints #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added package:lints/recommended and fixed all the lint warnings. API BREAK: EventSourceReadyState values are now camelCase instead of SCREAMING_CAPS.
Also removed the pubspec.lock from checkin.
|
The author line from the pubspec.yaml was only removed because pub yelled at me about it. It's no longer used I guess. 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added package:lints/recommended and fixed all the lint warnings.
API BREAK: EventSourceReadyState values are now camelCase instead of SCREAMING_CAPS.
This was almost entirely automated. I just pulled down the package, added the lints dependency and let the quickfixes in visual studio code do their thing.
I ran
dart testall tests passed.dart-lang/http#1 is now resolved, presumably removing the need for a separate BrowserClient, but I did not attempt to change that part of the API.