Fix CI setup #60
Merged
Fix CI setup #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requirement for `lcobucci/jwt` means that there is no way to install dependencies on PHP 7.2 or 7.4, making PHP 7.4 the de-facto requirement.
|
@steverhoades it looks like the |
|
7.4 as the minimum supported version makes sense at this point. I don't think code coverage is still needed, it can be dropped. Thank you for the contributions! |
Older versions are not compatible with the `lcobucci/jwt` requirement, leading to non-resolvable dependencies
|
@steverhoades this is now ready. I would also suggest dropping Scrutinizer entirely from this repo: code coverage is not uploaded anymore (which requires disabling it on their side so that they don't wait for it, blocking concurrent runs) and their static analysis is a lot less powerful than phpstan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requirement for
lcobucci/jwtmeans that there is no way to install dependencies on PHP 7.2 or 7.4, making PHP 7.4 the de-facto requirement.