Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

fixes #39 by downloading to a temporary directory #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes #39 by downloading to a temporary directory #45

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 8, 2019

To prevent overwriting files downloaded earlier, download into a temporary directory. Only if the complete download was successful, move the files to the target directory.

@stevespringett
Copy link
Owner

This needs resolved

@ghost
Copy link
Author

ghost commented Oct 18, 2019

If I undestand the existing code correctly, the .meta file is used to check if a download is needed:

before = readLocalMetaForURL(cveBaseMetaUrl);

Since my PR ignores the existing .meta files, it downloads files that don't have to be downloaded. I think I will have to rework the logic of this branch before it can be merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant